Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat code #60

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from
Open

Reformat code #60

wants to merge 12 commits into from

Conversation

FJShen
Copy link

@FJShen FJShen commented Jun 26, 2023

Fix Issue 207 in Accel-Sim: accel-sim/accel-sim-framework#207

The following pre-commit hooks are run on the repo:

  • clang-format
  • black
  • end-of-file-fixer
  • trailing-whitespace

Besides, some sporadic formatting imperfections are improved (e.g. non UTF-8 encoding, use of CRLF).

Finally, the pre-commit config file is added. For clang-format, the configuration file specifies exactly the same set of files outlined in format-code.sh

Copy link
Author

@FJShen FJShen Jun 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly the "before" version looks better. But if we want to integrate pre-commit formatting in the github workflow, it's not worth creating an exception just for this piece of code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants