Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bash source bug #167

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

fix bash source bug #167

wants to merge 6 commits into from

Conversation

clevercool
Copy link

If the execution shell is not bash, $BASH_SOURCE will be null and the script will put nvbit_release in the root folder leading to compile error.
Add the #!/bin/bash to make sure this script is executed by the bash shell and put the file in the correct position.

JRPan and others added 2 commits April 4, 2022 21:39
@JRPan JRPan requested a review from tgrogers February 14, 2023 20:26
@JRPan
Copy link
Collaborator

JRPan commented Feb 14, 2023 •
edited
Loading

@tgrogers looks good to me. What do you think

@JRPan JRPan changed the base branch from release to dev February 14, 2023 22:36
@JRPan JRPan requested review from JRPan and removed request for tgrogers February 17, 2023 00:57
@JRPan JRPan self-requested a review May 25, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JRPan JRPan Awaiting requested review from JRPan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@clevercool @JRPan @William-An