Lighthouse review indicated we should be more secure about how we op… #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en external links. This still keeps the referrer information when linking through from our site but it does not give the opened target the ability to take over our context. While we dont ask for any personal information its still best not to let something happen in the background when they open a link. This should helpfully mitigate some of that potential
kenman345
requested review from
deadr0ck,
hegjon,
chaintuts,
rawb0t and
t0p0lin0
as code owners
…nly loading the twitter timeline after scrol. This means we get faster initial loads before twitter timeline comes into play which may end up being removed shortly.
Also, lets lazy load those .svg images that take differing amounts of time to load. They're on the bottom of the page anyways so lets load them only when we scroll down that far.
zquestz
approved these changes
May 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…en external links. This still keeps the referrer information when linking through from our site but it does not give the opened target the ability to take over our context.
While we dont ask for any personal information its still best not to let something happen in the background when they open a link. This should helpfully mitigate some of that potential
Not sure guys if we need this but just going through to follow best practices on these things. We can choose to not pull this in if we decide its unnecessary for our site.