Patch 0.8.1 #241
Merged
Patch 0.8.1 #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-Pixie
requested changes
Jan 22, 2024
Instead of using the advanced using_test_classes, we can just stub the constants. You could use let statements for some of these as well, but when you want to do slightly more, like wrapping the class in a module, stubbing constants is much easier. I think it's best to keep things consistent here, so I decided to make all test classes into stubbed constants. It's very easy to read as well. https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/LeakyConstantDeclaration
1.39 was the newest codeclimate rubocop channel available, so I downgrades Rubocop to 1.39. No need to run a newer version than that right now...
"Users may let RuboCop know the oldest version of Ruby which your project supports with".
This test was not needed anymore since Fortnox has changed the behavior of the API.
d-Pixie
reviewed
Jan 23, 2024
There was a problem hiding this comment.
Why are we removing South Korea?
There was a problem hiding this comment.
The country code was changed and we didn't really need this test when the country gem was upgraded. We already have multiple tests with different country codes. This was the same change I did in the development branch.
| @@ -19,16 +19,16 @@ | |||
| # When recording new VCR cassettes, code needs to be changed to a unique value | |||
| include_examples '.save', | |||
| :description, | |||
| additional_attrs: { code: 'blarg5' } | |||
| additional_attrs: { code: 'blarg7' } | |||
There was a problem hiding this comment.
... Could we in future use reasonable strings for test data? Run a lorem word if you can't think of something appropriate 🙂
d-Pixie
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picks commits to add support for Ruby 3 to v0.8