This repository has been archived by the owner on Apr 16, 2024. It is now read-only.
Configuration schema validation moved after $extend import #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation extend before validating with JSON schema
* Changed RuntimeException to more specific InvalidArgumentException * Improved exception messages * Extracted Configuration::load into Configuration::importExtendedConfiguration and Configuration::processEventSubscribers * Moved Configuration::importExtendedConfiguration call before Configuration::validateSchema
niels-nijens
added a commit
that referenced
this pull request
Oct 31, 2015
Configuration schema validation moved after $extend import
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved Configuration schema validation to after $extend import to facilitate importing of required JSON elements.
Also improved the following: