Skip to content
This repository has been archived by the owner on Nov 19, 2020. It is now read-only.

Seems like Chessboard distance is incorrect #206

Closed
MonsterMMORPG opened this issue Mar 3, 2016 · 3 comments
Closed

Seems like Chessboard distance is incorrect #206

MonsterMMORPG opened this issue Mar 3, 2016 · 3 comments

Comments

@MonsterMMORPG
Copy link

According to the wikipedia

Chebyshev and Chessboard distance are the same thing

But when i test both, i get different results

How come?

https://en.wikipedia.org/wiki/Chebyshev_distance

http://accord-framework.net/docs/html/M_Accord_Math_Distance_Chessboard.htm

http://accord-framework.net/docs/html/M_Accord_Math_Distance_Chebyshev.htm

@cesarsouza
Copy link
Member

@DiegoCatalano do you know why those two implementations are different in the framework? I think one of them came from one of your contributions, and the other already existed in the framework. If its the case, we have to remove one of them!

@DiegoCatalano
Copy link
Contributor

Yes, I had implemented wrong. @MonsterMMORPG has reason, Chebyshev and Chessboard are the same. In this line in the cheeboard I forget to calculate the absolute number, while the chebyshev is correct. However, just delete the chessboard.

@cesarsouza
Copy link
Member

Fixed in release 3.2.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants