Skip to content
This repository has been archived by the owner on Nov 19, 2020. It is now read-only.

Debug unit tests failing because of checked code in RNG #924

Closed
CatchemAL opened this issue Sep 30, 2017 · 1 comment · Fixed by #926
Closed

Debug unit tests failing because of checked code in RNG #924

CatchemAL opened this issue Sep 30, 2017 · 1 comment · Fixed by #926
Assignees
@CatchemAL
Milestone
3.8

Comments

@CatchemAL
Copy link
Collaborator

I added some tests to check the ObjectNullReferenceException when the RNG was seeded (GH-921). In debug build, the code is checked so this code can randomly fail with an overflow exception. There weren't any tests for this code before and it's random so I didn't spot it yesterday.

There are three places where this occurs. I've added unit tests that generate 100 random numbers to check this is fixed now. Also, I set the seed to a number that would otherwise overflow for reproducibility purposes.

TestZigguratExponentialGenerator_Unseeded_NeverOverflows()
TestZigguratGenerator_Unseeded_NeverOverflows()
@CatchemAL CatchemAL self-assigned this Sep 30, 2017
CatchemAL added a commit that referenced this issue Sep 30, 2017
@CatchemAL
[GH-924, GH-925] Fixing the seeded exponential generator. Fixing issu…
ef7bb1f 
…e with checked code in Debug mode causing tests to fail.
@CatchemAL CatchemAL mentioned this issue Sep 30, 2017
Merged
cesarsouza added a commit that referenced this issue Sep 30, 2017
@cesarsouza
Merge pull request #926 from accord-net/GH-924
f085def 
Fixes to the exponential rng and addressing an issue in debug mode unit testing.

This closes #924
This fixes #925
@cesarsouza cesarsouza added this to the 3.8 milestone Oct 22, 2017
@cesarsouza
Copy link
Member

Added in 3.8.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@CatchemAL CatchemAL

Labels
None yet
Projects
None yet
Milestone
3.8
Development

Successfully merging a pull request may close this issue.

[GH-924, GH-925] RNG fixes accord-net/framework
2 participants
@cesarsouza @CatchemAL