Skip to content
This repository has been archived by the owner on May 19, 2020. It is now read-only.

feat(components): support ClauseComponent header color schemes - I132 #133

Merged
merged 4 commits into from
Sep 3, 2019
Merged

feat(components): support ClauseComponent header color schemes - I132 #133

merged 4 commits into from
Sep 3, 2019

Conversation

irmerk
Copy link
Member

@irmerk irmerk commented Aug 30, 2019

Issue #132

Provide color and background color support for ClauseComponent

Changes

  • Add two new optional props
    • Color the heading font
    • Color the background of the header and delete icon

Flags

Related Issues

N/A

Signed-off-by: irmerk <jolenelanglinais@gmail.com>
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk irmerk added the Type: Feature Request 🛍️ New feature or request label Aug 30, 2019
@irmerk irmerk self-assigned this Aug 30, 2019
Copy link
Member

@DianaLease DianaLease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't the HEADER_GRADIENT_BACKGROUND just use the CLAUSE_BACKGROUND value that is already being passed in to create the gradient since it will it always be going from white to the clause background color? Or do you expect users to want a different custom gradient?

Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
Copy link
Member Author

irmerk commented Sep 3, 2019

Can't the HEADER_GRADIENT_BACKGROUND just use the CLAUSE_BACKGROUND value that is already being passed in to create the gradient since it will it always be going from white to the clause background color? Or do you expect users to want a different custom gradient?

This is a great point. I think we can rely on the contract editor background being white, so any gradient will be from white to something else.

Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@DianaLease DianaLease self-requested a review September 3, 2019 15:58
@irmerk irmerk merged commit 6e054f7 into accordproject:master Sep 3, 2019
@irmerk irmerk deleted the irmerk/i132/clause-component-header branch September 3, 2019 17:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Feature Request 🛍️ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants