feat(ClausePlugin): handle paste functionality with clauses - I134

[irmerk]

Issue #134

Create new uuid for a clause that was copy/pasted in conjunction with this PR in markdown-editor

Changes

• On a paste event, we take the Document on the event and make it mutable in order to change the clauseid to a uuid and revert everything to immutable
• Abstracted clause specific logic out of @accordproject/markdown-editor

Flags

• Further issues should consider:

  • Handling different transfer.type situations

    • Editor instance (Slate) to another editor instance (Slate)
    • Raw HTML (Chrome to VSCode to Chrome)
    • Editor instance (Slate) to Google Docs and back (recognize <clause> formatting)

  • Ensure onPaste handlers are not doubling up work for any transfer.type cases

    • @accordproject/cicero-ui/src/plugins/ClausePlugin
    • @accordproject/markdown-editor/src/SlateAsInputEditor

  • What fragment.type results when copying pasting from one editor to another instance of an editor?

    • fragment as a transfer.type is a Slate DOM block fragment, not HTML anymore, so copying and pasting from the same editor into itself should be a fragment
    • However, copying pasting from one editor to another instance of an editor may result in HTML or fragment, needs experimentation

  • Preserve formatting, if H1 in HTML, we should be preserving the formatting

    • Slate has a mechanism for mapping from HTML tags to Slate blocks here

• Further work is needed in the redux store of TSv2, showcased here where the new uuid's placed onto the clauses are not represented in the store, and moreover the extra pasted clause does not appear at all:

DOM:

Store:

Related Issues

• TSv2 Issue 85
• Markdown Editor Issue 88

[DianaLease]

LGTM. Can we move those "flags" into an issue to keep track of?

[irmerk]

LGTM. Can we move those "flags" into an issue to keep track of?

Absolutely, yes I will be breaking these all into issues.