Skip to content
This repository has been archived by the owner on May 19, 2020. It is now read-only.

refactor(plugins): handle paste of new clause node structure - I134 #227

Merged
merged 2 commits into from
Nov 19, 2019
Merged

refactor(plugins): handle paste of new clause node structure - I134 #227

merged 2 commits into from
Nov 19, 2019

Conversation

irmerk
Copy link
Member

@irmerk irmerk commented Nov 19, 2019

Issue #134

Handle Duplicate clauseId from Copy/Paste

Changes

  • Adjust clausesToParse to be nodes instead of a larger object
  • Mutate mutableNodes to have changes persist

Flags

  • Current issues persist with key or path in Slate, may be as a result of npm link.
    • Will test post-publishing in template-studio-v2 and resume these issues

Related Issues

@irmerk
refactor(plugins): handle paste of new clause node structure - I134
8d0f73a 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
chore(package): increment markdown-editor - I134
f3fe378 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk irmerk self-assigned this Nov 19, 2019
@irmerk irmerk added this to In Progress PR in Cicero UI v1.0 via automation Nov 19, 2019
DianaLease
DianaLease approved these changes Nov 19, 2019
View reviewed changes
Copy link
Member

@DianaLease DianaLease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@irmerk irmerk merged commit ab285ca into accordproject:master Nov 19, 2019
Cicero UI v1.0 automation moved this from In Progress PR to Finished PR Nov 19, 2019
@irmerk irmerk deleted the irmerk/i134/copy-paste-clause branch November 19, 2019 18:18
@DianaLease DianaLease mentioned this pull request Nov 19, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DianaLease DianaLease DianaLease approved these changes

@dselman dselman Awaiting requested review from dselman

@jeromesimeon jeromesimeon Awaiting requested review from jeromesimeon

Assignees

@irmerk irmerk

Labels
Difficulty: Challenging Type: Feature Request 🛍️ New feature or request
Projects
No open projects
Cicero UI v1.0
  
Finished PR
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@irmerk @DianaLease