-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(*): add docstrings - #37 #38
Changes from all commits
ae1dd1e
5245d32
50f5e2b
cc50ddf
9df6f82
6774335
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,8 +16,8 @@ | |
"build:dev": "webpack --mode development --https false", | ||
"build-dev": "webpack --mode development --https false && echo . && echo . && echo . && echo Please use 'build:dev' instead of 'build-dev'.", | ||
"dev-server": "webpack-dev-server --mode development", | ||
"lint": "eslint **/*.{js,jsx}", | ||
"lint:fix": "eslint **/*.{js,jsx} --fix", | ||
"lint": "eslint '**/*.{js,jsx}'", | ||
"lint:fix": "eslint '**/*.{js,jsx}' --fix", | ||
"start": "office-addin-debugging start manifest.xml", | ||
"start:desktop": "office-addin-debugging start manifest.xml desktop", | ||
"start:web": "office-addin-debugging start manifest.xml web", | ||
|
@@ -49,6 +49,7 @@ | |
"copy-webpack-plugin": "^6.0.1", | ||
"css-loader": "^3.0.0", | ||
"eslint": "^7.1.0", | ||
"eslint-plugin-jsdoc": "^32.3.0", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Even after adding this package, I don't get an error when I run There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @algomaster99 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Why have you added it then? Can you tell its purpose? Does it only check the syntax of the JSDoc? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @algomaster99 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @algomaster99 |
||
"eslint-plugin-react": "^7.16.0", | ||
"extract-text-webpack-plugin": "4.0.0-beta.0", | ||
"file-loader": "^4.2.0", | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these quotes needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@algomaster99
If no quotation marks are applied, then this issue occurs.
So the quotation marks are required for the lint command to run properly.