Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(*): render list of AP templates #6

Merged
merged 6 commits into from Jun 10, 2020
Merged

feat(*): render list of AP templates #6

merged 6 commits into from Jun 10, 2020

Conversation

algomaster99
Copy link
Member

No description provided.

algomaster99 and others added 5 commits June 8, 2020 23:50
@algomaster99
feat(TemplateLibrary): initialize the component for listing the templ…
ce88c0e 
…ates

Signed-off-by: Aman Sharma <mannu.poski10@gmail.com>
@DianaLease @algomaster99
fix(*): install peer deps, ignore child_process, update undefined vars
d257c8b 
Signed-off-by: Diana Lease <dianarlease@gmail.com>
@algomaster99
refactor(TemplateLibrary/index.js): update props for TemplateLibraryR…
401107e 
…enderer

Signed-off-by: Aman Sharma <mannu.poski10@gmail.com>
@algomaster99
style(*): add styling configuration
27ebf82 
Signed-off-by: Aman Sharma <mannu.poski10@gmail.com>
@algomaster99
fix(*): improve styles of startup container
89cc8c5 
Signed-off-by: Aman Sharma <mannu.poski10@gmail.com>
@algomaster99 algomaster99 added this to the View AP Templates milestone Jun 9, 2020
@algomaster99 algomaster99 added this to In progress in Word Add in Progress Jun 9, 2020
@algomaster99
refactor(package.json): remove slate-* dependencies and import `Libra…
3f182b0 
…ry` from @accordproject/ui-components

Signed-off-by: Aman Sharma <mannu.poski10@gmail.com>
@irmerk
Copy link
Member

irmerk commented Jun 10, 2020

I think this looks good so far, are you ready for us to take a 👀 at it?

@algomaster99
Copy link
Member Author

@irmerk yeah, sure. This only renders the list. The buttons in the templates don't work yet.

@irmerk irmerk requested review from irmerk and DianaLease June 10, 2020 17:47
DianaLease
DianaLease approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@DianaLease DianaLease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! We'll want to iterate on the styling, add padding around the library component, etc, but this is a great start to get the component integrated with the Word add-in :)

@algomaster99
Copy link
Member Author

@DianaLease thanks! I would focus more on styling once I am able to add text in the document. That is quite daunting task 😅

@algomaster99 algomaster99 merged commit a15365f into master Jun 10, 2020
Word Add in Progress automation moved this from In progress to Done Jun 10, 2020
@algomaster99 algomaster99 deleted the dl-cicero-imports branch June 10, 2020 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DianaLease DianaLease DianaLease approved these changes

@irmerk irmerk Awaiting requested review from irmerk

Assignees

@algomaster99 algomaster99

Labels
None yet
Projects
Word Add in Progress
  
Done
Milestone
View AP Templates
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@algomaster99 @irmerk @DianaLease