feat(apply): added cli support for decorators and vocab #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 19, 2023 16:57
Signed-off-by: Muskan Bararia <muskan.b@docusign.com>
Signed-off-by: Muskan Bararia <muskan.b@docusign.com>
mttrbrts
reviewed
Oct 19, 2023
There was a problem hiding this comment.
A nice PR, thanks @muskanbararia!
My comments are mostly stylistic and related to standardisation of the command line flags.
muskanbararia
force-pushed
the
muskanbararia/i34/added-cli-support-for-decorators-and-vocab
branch
from
f5b3133
to
ef8a48b
Compare
Signed-off-by: Muskan Bararia <muskan.b@docusign.com>
muskanbararia
force-pushed
the
muskanbararia/i34/added-cli-support-for-decorators-and-vocab
branch
from
ef8a48b
to
3976284
Compare
mttrbrts
approved these changes
Oct 19, 2023
added 4 commits
October 23, 2023 22:10
Signed-off-by: Muskan Bararia <muskan.b@docusign.com>
…vocab' of https://github.com/muskanbararia/concerto-cli into muskanbararia/i34/added-cli-support-for-decorators-and-vocab
Signed-off-by: Muskan Bararia <muskan.b@docusign.com>
…vocab' of https://github.com/muskanbararia/concerto-cli into muskanbararia/i34/added-cli-support-for-decorators-and-vocab
auto-merge was automatically disabled
October 24, 2023 10:01
Head branch was pushed to by a user without write access
added 2 commits
October 25, 2023 18:23
Signed-off-by: Muskan Bararia <muskan.b@docusign.com>
…vocab' of https://github.com/muskanbararia/concerto-cli into muskanbararia/i34/added-cli-support-for-decorators-and-vocab
|
@dselman I have added the testcase for dependent models as well |
added 2 commits
October 27, 2023 11:12
Signed-off-by: Muskan Bararia <muskan.b@docusign.com>
…vocab' of https://github.com/muskanbararia/concerto-cli into muskanbararia/i34/added-cli-support-for-decorators-and-vocab
mttrbrts
approved these changes
Nov 13, 2023
added 3 commits
November 13, 2023 15:29
…into muskanbararia/i34/added-cli-support-for-decorators-and-vocab
…into muskanbararia/i34/added-cli-support-for-decorators-and-vocab
Signed-off-by: Muskan Bararia <muskan.b@docusign.com>
Pull Request Test Coverage Report for Build 6848537100
💛 - Coveralls |
muskanbararia
force-pushed
the
muskanbararia/i34/added-cli-support-for-decorators-and-vocab
branch
from
8cd89c0
to
fed2a92
Compare
Signed-off-by: Muskan Bararia <muskan.b@docusign.com>
mttrbrts
dismissed
dselman’s stale review
Comments addressed in subsequent commits
mttrbrts
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Added support for applying decorators and vocab to a model
Closes #34
Added command for applying a list of decorators and/or vocabularies to a given model. The output can be either json or cto, depending on the args
Changes
Author Checklist
--signoffoption of git commit.mainfromfork:branchname