New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concerto analysis changes #719

Open

DianaLease opened this issue Sep 27, 2023 · 2 comments

Assignees

Milestone

Member

DianaLease commented Sep 27, 2023 •

edited

Loading

Bug Report 🐛

Concerto analysis returns no change for:

Changing a default value (maybe also adding one?)
changing a range to be less restrictive
adding/removing optional from a property
Importing a different minor or patch version

Expected Behavior

Removing optional from property should be a breaking change.
The rest should probably be patch or minor
Possibly add way to extend config to add your own rules to use

Current Behavior

Possible Solution

Steps to Reproduce

Context (Environment)

Desktop

OS: [e.g. macOS]
Browser: [e.g. Chrome, Safari]
Version: [e.g. 0.22.15]

Detailed Description

Possible Implementation

The text was updated successfully, but these errors were encountered:

Contributor

ekarademir commented Sep 27, 2023

Cases I found that are considered no change by the analyser:

Adding a default value to a scalar
Removing a default value from a scalar
Changing the value of the default value of a scalar
Changing the minor or patch version of an imported type of a property

ekarademir mentioned this issue

v4 Planning #706

Closed

Contributor

ekarademir commented Nov 2, 2023

Changing argument list of a decorator of a property
Adding a decorator of a property
Removing a decorator of a property

mttrbrts added this to the v4.0 milestone

mttrbrts assigned ekarademir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment