Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CI) Align github workflows with cicero #236

Merged
merged 3 commits into from
Mar 18, 2021
Merged

Conversation

jeromesimeon
Copy link
Member

Signed-off-by: Jerome Simeon jeromesimeon@me.com

Why

We need to do a second round of design on CI migration from Travis to GitHub Actions because:

  1. we have to variants now with slightly different takes in https://github.com/accordproject/concerto/tree/master/.github/workflows and https://github.com/accordproject/cicero/tree/master/.github/workflows
  2. We need to decide which node version we support
  3. Better to maintain one well understood version to make our lives easier
  4. Travis is being very capricious and the matter feels more urgent than it was a year ago

Changes

  • Consolidate GitHub action workflows for build/testing/publication to npm

Flags

  • Still draft, one key question is when is lerna installed and how, but want this PR ready for discussion on Tech WG call

@irmerk
Copy link
Member

irmerk commented Mar 17, 2021

Is this off of accordproject/technical-steering-committee#4?

@irmerk irmerk added the Type: Enhancement ✨ Improvement to process or efficiency label Mar 17, 2021
@jeromesimeon
Copy link
Member Author

Is this off of accordproject/technical-steering-committee#4?

Indeed it is

@jeromesimeon jeromesimeon force-pushed the js-travis-cleanup branch 2 times, most recently from 4359ed5 to 41491de Compare March 17, 2021 22:34
Signed-off-by: Jerome Simeon <jeromesimeon@me.com>
@jeromesimeon jeromesimeon force-pushed the js-travis-cleanup branch 4 times, most recently from 0c1fa29 to 3c25892 Compare March 18, 2021 05:09
Signed-off-by: Jerome Simeon <jeromesimeon@me.com>
@jeromesimeon jeromesimeon marked this pull request as ready for review March 18, 2021 05:23
Signed-off-by: Jerome Simeon <jeromesimeon@me.com>
@jeromesimeon
Copy link
Member Author

@mttrbrts Update on this one:

  1. Fixed a few things in the script, they work for building, testing and timestamp deployment on Windows/MacOS/Unbuntu
  2. Caching seems to work (new feature)
  3. Added logic to disable npm publication in forks (so people forking the repo should be safe now)
  4. Previous features still working include code coverage
  5. Cleaner than previous script by using npx lerna
  6. Still need to re-test publication on release (I will need to merge this PR to test that)

There are other improvements we could consider, but to me this feels like addressing our main requirements and a good initial "blueprint" we can use in other projects.

Once merged / tested I'll update markdown transform and cicero with the same scripts, but you're very welcome to do further improvements and we still need to switch the remaining projects.

@jeromesimeon jeromesimeon merged commit 41a9557 into master Mar 18, 2021
Copy link
Member

@mttrbrts mttrbrts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jeromesimeon . Adding a retrospective approval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement ✨ Improvement to process or efficiency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants