Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(decoratormanager): apply decorators to properties without a type #752

Merged
merged 1 commit into from
Nov 2, 2023
Merged

fix(decoratormanager): apply decorators to properties without a type #752

merged 1 commit into from
Nov 2, 2023

Conversation

dselman
Copy link
Contributor

@dselman dselman commented Nov 2, 2023 •
edited

Closes #751

Fixes logic and adds a test.

Changes

  • Fix logic in DecoratorManager
  • Add some tests for combinations of property / properties with and without types.

Flags

Screenshots or Video

Related Issues

  • Issue #
  • Pull Request #

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@dselman
fix(decoratormanager): apply decorators to properties without a type
d76d80d 
Signed-off-by: Dan Selman <danscode@selman.org>
@dselman dselman marked this pull request as ready for review November 2, 2023 15:52
@mttrbrts mttrbrts merged commit b4140f6 into main Nov 2, 2023
11 checks passed
@mttrbrts mttrbrts deleted the ds-decorator-fix branch November 2, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mttrbrts mttrbrts mttrbrts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decorator Command with properties without a type adds decorator to declaration
2 participants
@dselman @mttrbrts