Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vocabulary): vocaulary for map types #755

Merged

Conversation

sanketshevkar
Copy link
Member

@sanketshevkar sanketshevkar commented Nov 6, 2023

Closes #735

Changes

  • Modified generateDecoratorCommand to generate command-sets for map keys and values
  • Modified validate in vocabulary.js to validate for missingTerms and Additional terms for map declarations, key and value.
  • In concerto-core added helper methods to getNamespace for map keys and values and isMapDeclaration method for ScalarDeclaration

Flags

  • Should have KEY VALUE as reserved constants in concerto?

Related Issues

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

Signed-off-by: Sanket Shevkar <Sanket.Shevkar@docusign.com>
Signed-off-by: Sanket Shevkar <Sanket.Shevkar@docusign.com>
Signed-off-by: Sanket Shevkar <sanket.shevkar@docusign.com>
Copy link
Member

@jonathan-casey jonathan-casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a clear example of the bug the added 'else' branch fixes, in the form of a test case and a sample command, or remove the branch entirely if it is deemed a false positive.

Signed-off-by: Sanket Shevkar <sanket.shevkar@docusign.com>
@sanketshevkar
Copy link
Member Author

Please provide a clear example of the bug the added 'else' branch fixes, in the form of a test case and a sample command, or remove the branch entirely if it is deemed a false positive.

Addressed.

@DianaLease DianaLease mentioned this pull request Nov 8, 2023
@mttrbrts mttrbrts added this to the v3.x milestone Nov 8, 2023
Signed-off-by: Sanket Shevkar <Sanket.Shevkar@docusign.com>
Signed-off-by: Sanket Shevkar <Sanket.Shevkar@docusign.com>
@mttrbrts mttrbrts merged commit 53abb6d into accordproject:main Nov 14, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Vocabulary support for Map Types in Concerto
5 participants