Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!(core): detect ambiguous imports / declarations #800

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

mttrbrts
Copy link
Sponsor Member

@mttrbrts mttrbrts commented Feb 5, 2024

Closes #648

Changes

  • Detects when local declarations have the same shortname as an imported type
  • Most of the changes here are fixing tests that previously relied on this behaviour

Flags

  • The side-effect is that you can no longer declare a type with the same name as a System type (because the system namespace is implicitly imported in all Model files).

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

Signed-off-by: Matt Roberts <code@rbrts.uk>
Signed-off-by: Matt Roberts <code@rbrts.uk>
@mttrbrts mttrbrts merged commit e4cdc25 into accordproject:v4.0.0 Feb 6, 2024
9 checks passed
@mttrbrts mttrbrts deleted the mr-fix-648 branch February 6, 2024 16:51
hereje pushed a commit to hereje/concerto that referenced this pull request Feb 29, 2024
* fix(core): detect ambiguous imports / declarations

Signed-off-by: Matt Roberts <code@rbrts.uk>

* fix(lint): assetdeclaration

Signed-off-by: Matt Roberts <code@rbrts.uk>

---------

Signed-off-by: Matt Roberts <code@rbrts.uk>
Signed-off-by: Angel Mendez Cano <amendez1988@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants