Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed no such file or directory error in decoratormanager.js Test File #837

Merged
merged 4 commits into from May 1, 2024

Conversation

subhajit20
Copy link
Contributor

@subhajit20 subhajit20 commented Apr 6, 2024

Closes #836

Changes

  • Added __dirname keyword as prefix of every path of the .cto file
  • Screenshot 2024-04-06 at 9 26 05 PM

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

Signed-off-by: Subhajit Ghosh <subhajitstd07@gmail.com>
@subhajit20
Copy link
Contributor Author

Hey @DianaLease can you please review this pr?

Signed-off-by: Subhajit Ghosh <subhajitstd07@gmail.com>
@DianaLease
Copy link
Member

DianaLease commented Apr 10, 2024

What OS and Node version are you using? Any other specific details about your environment? Wondering why this is failing for you.

@subhajit20
Copy link
Contributor Author

subhajit20 commented Apr 10, 2024

What OS and Node version are you using? Any other specific details about your environment? Wondering why this is failing for you.

I am using Mac OS and my node version is v18.3.0.
When I execute the test file from the root of the repo then I get this error but if I specifically go inside concerto-core folder and try to execute then file the it worked fine. I used npx mocha command to run the file and there are other test files where I have faced similar issue as well

Signed-off-by: Subhajit Ghosh <subhajitstd07@gmail.com>
@DianaLease
Copy link
Member

What OS and Node version are you using? Any other specific details about your environment? Wondering why this is failing for you.

I am using Mac OS and my node version is v18.3.0. When I execute the test file from the root of the repo then I get this error but if I specifically go inside concerto-core folder and try to execute then file the it worked fine. I used npx mocha command to run the file and there are other test files where I have faced similar issue as well

I see. So with this change, will will it work from both the root and from concerto-core? @subhajit20

@subhajit20
Copy link
Contributor Author

What OS and Node version are you using? Any other specific details about your environment? Wondering why this is failing for you.

I am using Mac OS and my node version is v18.3.0. When I execute the test file from the root of the repo then I get this error but if I specifically go inside concerto-core folder and try to execute then file the it worked fine. I used npx mocha command to run the file and there are other test files where I have faced similar issue as well

I see. So with this change, will will it work from both the root and from concerto-core? @subhajit20

Yup! It is working fine right now after making these changes done both from the root and the concerto-core or any other packages Directory

@subhajit20 subhajit20 changed the title Fixed no such file or directory error inside in decoratormanager.js Test File Fixed no such file or directory error in decoratormanager.js Test File Apr 19, 2024
@mttrbrts mttrbrts merged commit bfeb53f into accordproject:main May 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix no such file or directory error inside in decoratormanager.js Test File
3 participants