fix(src): handle new form of list item as paragraph - I192 #194

irmerk · 2019-11-15T21:46:59Z

Issue #192

Adjust the handling of lists with the new paragraph support in markdown-transform v0.8

Changes

Keep focus when clicking a block in the toolbar
Handle block types as constants
Handle breakout of empty list item
Modularize and refactor code
- Block action methods
- onClickBlock handler
- Handle lists onEnter in the plugin

Flags

Work still needed for this PR
- ~~Persisting issue around block_quote to list_item, requires further work~~
- ~~Formatting Toolbar buttons don't yet recognize the selection being in a list~~
Future Issues
- Work around SHIFT + ENTER handling a linebreak / new paragraph in a list_item is needed

Related Issues

N/A

irmerk · 2019-11-15T21:49:07Z

Netlify deployment

mttrbrts · 2019-11-15T21:53:48Z

src/plugins/list.js

+        event.preventDefault();
+        editor.splitBlock().unwrapBlock(CONST.LIST_ITEM).wrapBlock(CONST.LIST_ITEM);
+      });
+      return true;


What is the effect of this? Shouldn't it return next() instead?

I think next() is resulting in there being a paragraph in the list_item and a new paragraph below, as if a sibling of the list_item.

I'm confused about this as well. What should be the type returned by onEnter ?

I'm unsure if it should be returning a type. @dselman you may have some insight?

~~What is .unwrapBlock(CONST.LIST_ITEM).wrapBlock(CONST.LIST_ITEM) doing on line 37? Why would we unwrap a list item just to wrap it again?~~ moved comment to correct line

Signed-off-by: irmerk <jolenelanglinais@gmail.com>

… - I192 Signed-off-by: irmerk <jolenelanglinais@gmail.com>

Signed-off-by: irmerk <jolenelanglinais@gmail.com>

jeromesimeon

Some questions.

jeromesimeon · 2019-11-18T16:33:45Z

src/schema.js

@@ -89,8 +89,6 @@ const schema = {
      nodes: [
        {
          match: [
-            { object: 'text' },
-            { type: 'link' },


Shouldn't this include lists as well?

I believe so, but I think that should be left for another issue when we add support for nested lists.

src/plugins/list.js

jeromesimeon · 2019-11-18T16:36:23Z

src/plugins/list.js

+        event.preventDefault();
+        editor.splitBlock().unwrapBlock(CONST.LIST_ITEM).wrapBlock(CONST.LIST_ITEM);
+      });
+      return true;


I'm confused about this as well. What should be the type returned by onEnter ?

Signed-off-by: irmerk <jolenelanglinais@gmail.com>

DianaLease · 2019-11-18T19:41:39Z

src/plugins/list.js

+    if (isSelectionInput(value, CONST.LIST_ITEM) && startBlock.text.length !== 0) {
+      editor.withoutNormalizing(() => {
+        event.preventDefault();
+        editor.splitBlock().unwrapBlock(CONST.LIST_ITEM).wrapBlock(CONST.LIST_ITEM);


What is .unwrapBlock(CONST.LIST_ITEM).wrapBlock(CONST.LIST_ITEM) doing on line 37? Why would we unwrap a list item just to wrap it again?

I made this diagram that hopefully helps explain the process. Essentially when splitBlock is called, there are two child paragraph nodes under a list_item. So now the list_item is acting as if it itself an ul_list. When unwrapBlock is called, it moves this new node from the split up one level, but now it is not under a list_item. So wrapping back puts it under a list_item which stems from the ol_list

Thanks for explaining this. Makes sense now!

irmerk added Type: Bug 🐛 Something isn't working Difficulty: Medium Type: Enhancement ✨ Improvement to process or efficiency labels Nov 15, 2019

irmerk requested review from dselman, jeromesimeon, mttrbrts and DianaLease November 15, 2019 21:46

irmerk self-assigned this Nov 15, 2019

irmerk added this to In Progress PR in Cicero UI v1.0 via automation Nov 15, 2019

mttrbrts reviewed Nov 15, 2019

View reviewed changes

irmerk added 12 commits November 18, 2019 11:32

refactor(constants): export block types as constants - I192

dd11c0e

Signed-off-by: irmerk <jolenelanglinais@gmail.com>

refactor(FormattingToolbar): update block handling for new list types…

2e77727

… - I192 Signed-off-by: irmerk <jolenelanglinais@gmail.com>

fix(FormattingToolbar): keep focus when clicking block - I192

5bf7666

Signed-off-by: irmerk <jolenelanglinais@gmail.com>

feat(SlateAsInputEditor): handle breakout of empty list item - I192

09daaf4

Signed-off-by: irmerk <jolenelanglinais@gmail.com>

refactor(FormattingToolbar): modularize block action methods - I192

f4a2a9e

Signed-off-by: irmerk <jolenelanglinais@gmail.com>

fix(schema): allow list items to use paragraph qualities - I192

6393073

Signed-off-by: irmerk <jolenelanglinais@gmail.com>

chore(FormattingToolbar): cleanup comments - I192

9935cad

Signed-off-by: irmerk <jolenelanglinais@gmail.com>

refactor(FormattingToolbar): clarify code with ternaries - I192

caacd4e

Signed-off-by: irmerk <jolenelanglinais@gmail.com>

docs(FormattingToolbar): explain methods - I192

d2249cc

Signed-off-by: irmerk <jolenelanglinais@gmail.com>

refactor(src): modularize list behavior on enter to plugin - I192

eb37c32

Signed-off-by: irmerk <jolenelanglinais@gmail.com>

refactor(src): better handle checking block types - I192

6b9a803

Signed-off-by: irmerk <jolenelanglinais@gmail.com>

fix(FormattingToolbar): handle to and from block_quote - I192

f9c73cc

Signed-off-by: irmerk <jolenelanglinais@gmail.com>

jeromesimeon reviewed Nov 18, 2019

View reviewed changes

test(FormattingToolbar): skip test until Slate is injected - I192

6a1d06f

Signed-off-by: irmerk <jolenelanglinais@gmail.com>

irmerk force-pushed the irmerk/i192/persist-lists branch from 6c8828c to 6a1d06f Compare November 18, 2019 16:37

refactor(plugins): unwrap once out of list - I192

82751d0

Signed-off-by: irmerk <jolenelanglinais@gmail.com>

irmerk requested review from mttrbrts and jeromesimeon November 18, 2019 19:21

DianaLease reviewed Nov 18, 2019

View reviewed changes

irmerk merged commit f946b38 into accordproject:master Nov 18, 2019

Cicero UI v1.0 automation moved this from In Progress PR to Finished PR Nov 18, 2019

irmerk deleted the irmerk/i192/persist-lists branch November 18, 2019 20:10

irmerk mentioned this pull request Nov 18, 2019

test(FormattingToolbar): init tests for buttons #166

Merged

irmerk mentioned this pull request Nov 26, 2019

fix(src): support heading actions #204

Merged

irmerk mentioned this pull request May 13, 2020

Support Nested Lists accordproject/web-components#31

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(src): handle new form of list item as paragraph - I192 #194

fix(src): handle new form of list item as paragraph - I192 #194

irmerk commented Nov 15, 2019 •

edited

irmerk commented Nov 15, 2019

mttrbrts Nov 15, 2019

irmerk Nov 15, 2019

jeromesimeon Nov 18, 2019

irmerk Nov 18, 2019

DianaLease Nov 18, 2019 •

edited

jeromesimeon left a comment

jeromesimeon Nov 18, 2019

irmerk Nov 18, 2019

jeromesimeon Nov 18, 2019

DianaLease Nov 18, 2019

irmerk Nov 18, 2019 •

edited

DianaLease Nov 18, 2019

fix(src): handle new form of list item as paragraph - I192 #194

fix(src): handle new form of list item as paragraph - I192 #194

Conversation

irmerk commented Nov 15, 2019 • edited

Issue #192

Changes

Flags

Related Issues

irmerk commented Nov 15, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DianaLease Nov 18, 2019 • edited

Choose a reason for hiding this comment

jeromesimeon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

irmerk Nov 18, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

irmerk commented Nov 15, 2019 •

edited

DianaLease Nov 18, 2019 •

edited

irmerk Nov 18, 2019 •

edited