Skip to content
This repository has been archived by the owner on May 19, 2020. It is now read-only.

feat(src): implement static formatting toolbar - I35 #42

Merged
merged 66 commits into from
May 31, 2019
Merged

feat(src): implement static formatting toolbar - I35 #42

merged 66 commits into from
May 31, 2019

Conversation

irmerk
Copy link
Member

@irmerk irmerk commented May 31, 2019 •
edited

Issue #35

Changes

  • Adjust linting
  • Install icons
    • Move into svg component
    • Include specifications
  • Implement static toolbar
    • Utilize portal
    • Render custom icons
    • Adjust styling
    • Optimize event handler with pointer events
  • Adjust plugin icon styling
    • Color change on active state
  • Create grid styling
  • Remove hover component
  • Adjust schema
    • Implement underline case
    • Add code support for lists
  • Modularize method functionality
  • List functionality
    • Handle list blocks to and from

Flags

  • Researching FormatToolbar functionality
  • Needs all button functionality corrected
  • Needs color change on active (already bolded, for example)
  • Needs parameter functionality
  • Needs fix for clicking list button on a list item twice.

irmerk added 30 commits May 31, 2019 13:44
@irmerk
chore(src): linting - I35
2033e62 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
chore(package): npm dependencies - I35
37413df 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
feat(FormatToolbar): initiate static toolbar - I35
76dc487 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
feat(css): initiate toolbar checkbox location - I35
dbecf83 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
feat(src): render toolbar - I35
ca223fc 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
chore(src): remove hover component - I35
5708c1d 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
feat(css): adjust grid alignment - I35
fecddf3 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
feat(plugins): adjust plugin icon style - I35
44fbb12 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
feat(src): adjust style and create id - I35
6c0eed5 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
feat(FormatToolbar): implement portal with custom icons - I35
39a6971 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
feat(public): install icons for toolbar - I35
ff50e70 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
chore(plugins): adjust jsdocs - I35
a704c0e 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
chore(*): pause for work in progress
e7a560a 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
feat(FormatToolbar): begin dynamic svg implementation - I35
c577d8b 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
feat(icons): implement bold svg as react component - I35
de2e3a0 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
feat(icons): implement code svg as react component - I35
29c74b7 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
feat(icons): move styling into svg component - I35
e62a222 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
feat(icons): move styling into svg component - I35
877f0e1 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
feat(FormatToolbar): adjust imports from svg components - I35
54950d3 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
feat(icons): adjust code style - I35
b0f2180 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
feat(plugins): add responsive design to plugin icon - I35
2519430 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
feat(FormatToolbar): import and adjust for new svg - I35
cfc952e 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
feat(icons): move ol svg to react component - I35
ab591be 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
feat(icons): move ul svg to react component - I35
c9f42a8 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
feat(icons): move hyperlink svg to react component - I35
e980d4c 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
feat(icons): move italic svg to react component - I35
1545a82 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
feat(icons): move back button svg to react component - I35
44ffb7c 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
feat(icons): move forward button svg to react component - I35
e8dcd80 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
feat(icons): move quote svg to react component - I35
2b54014 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
feat(icons): move param svg to react component - I35
61059d8 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
feat(FormatToolbar): adjust for method modularization - I35
63f7674 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk irmerk marked this pull request as ready for review May 31, 2019 18:13
@irmerk irmerk changed the title Jl toolbar merge feat(src): implement static formatting toolbar - I35 May 31, 2019
@irmerk irmerk self-assigned this May 31, 2019
@irmerk irmerk added the Type: Feature Request 🛍️ New feature or request label May 31, 2019
@irmerk
test(*): update snapshots - I35
7823628 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
chore(markdown): remove unnecessary code - I35
f12840b 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
chore(html): remove comments - I35
54a44e6 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
fix(FormatToolbar): adjust component name - I35
9650ad5 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
jeromesimeon
jeromesimeon approved these changes May 31, 2019
View reviewed changes
Copy link
Member

@jeromesimeon jeromesimeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new PR looks good to me

@irmerk irmerk requested review from dselman, jeromesimeon and DianaLease and removed request for jeromesimeon May 31, 2019 18:37
@jeromesimeon jeromesimeon mentioned this pull request May 31, 2019
Closed
@irmerk irmerk mentioned this pull request May 31, 2019
Closed
DianaLease
DianaLease reviewed May 31, 2019
View reviewed changes
Copy link
Member

@DianaLease DianaLease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Added a couple comments

src/index.js Outdated Show resolved Hide resolved
src/index.js Show resolved Hide resolved
@irmerk
fix(src): revert html case for mark type - I35
02e2bc0 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk irmerk merged commit 119cee7 into accordproject:master May 31, 2019
@irmerk irmerk deleted the jl-toolbar-merge branch May 31, 2019 19:09
This was referenced May 31, 2019
Closed
Closed
Closed
@irmerk irmerk added this to Finished PR in Template Studio V2 Jun 4, 2019
@irmerk irmerk mentioned this pull request May 13, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeromesimeon jeromesimeon jeromesimeon approved these changes

@DianaLease DianaLease DianaLease left review comments

@dselman dselman Awaiting requested review from dselman

Assignees

@irmerk irmerk

Labels
Type: Feature Request 🛍️ New feature or request
Projects
No open projects
Template Studio V2
  
Finished PR
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@irmerk @jeromesimeon @DianaLease