docs: seed allcontributor data #162
Conversation
kharaone
force-pushed
the
seed-contributor
branch
from
2ceb8fc
to
e8cba8b
Compare
irmerk
added
Difficulty: Medium
hacktoberfest
README.md
Outdated
| [apache]: https://github.com/accordproject/template-studio-v2/blob/master/LICENSE | ||
| [creativecommons]: http://creativecommons.org/licenses/by/4.0/ | ||
| <h1 align="center"> | ||
| [](#contributors-) |
There was a problem hiding this comment.
This doesn't render correctly,
Badges should sit below the AP logo
There was a problem hiding this comment.
the way the library detects the badge zone (in order to update it) is through a regex var badgeRegex = /\[!\[All Contributors\]\([a-zA-Z0-9\-./_:?=]+\)\]\(#[\w-]+\)/;, BUT markdown doesn't mix well with html.
I'll keep the logo centered, but I will need to move the badges on the left. Is that acceptable?
There was a problem hiding this comment.
Perhaps you can just empty the badgeTemplate config parameter, i.e. in .all-contributorsrc:
"badgeTemplate": "",
There was a problem hiding this comment.
it will only drive the rewriting of the badge to nothing ^^.
The library has hardcoded the regex to be the markdown tag. You can just change what's it's replaced with.
In order to "fix" this, we would need to PR to the allcontributor, to expose the regex in the options or leverage a block section like it does for the contributor list
kharaone
force-pushed
the
seed-contributor
branch
from
4e69323
to
6617a8e
Compare
Signed-off-by: kharaone <kharaone@gmail.com> Signed-off-by: Karim Adala <kadala@blizzard.com>
Signed-off-by: Karim Adala <kadala@blizzard.com>
contributor badge needs to be markdown but can't be mixed with html. Moving the badges to their own line without alignment to fix this Signed-off-by: Karim Adala <kadala@blizzard.com>
kharaone
force-pushed
the
seed-contributor
branch
from
6617a8e
to
9318306
Compare
|
Please notify the related issue when this is merged to kickstart the process in other repos. |
|
I created all-contributors/cli#210 to alleviate @mttrbrts 's concerns. However, I still feel that this PR could go through whether or not it's merged. |
|
@kharaone great work pushing the upstream PR too. I'm happy to merge this one as is for now. 🥇 |
Issue #100
Initial seed commit to initiate the data for allcontributor bot / cli
Provide an example to proceed with other repositories
Changes