This repository has been archived by the owner on May 7, 2020. It is now read-only.
fix: color contrast a11y #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: C Dharmateja <cdharmateja1999@gmail.com>
CDharmateja
force-pushed
the
color-contrast-a11y
branch
from
f77d1d5
to
b7c48bf
Compare
irmerk
added
A11Y 🔓
Michael-Grover
suggested changes
Oct 28, 2019
|
@CDharmateja wait, is this changing the color of the border in between the buttons or the text?
If it's the border, that doesn't need be changed. |
|
This is in conjunction with the PR in |
|
The color is changing the color of the text "Add to contract" (not border). |
irmerk
reviewed
Oct 28, 2019
irmerk
approved these changes
Oct 28, 2019
|
@CDharmateja please change the text color of "add to contract" to #19C6C7 so that it matches the "details" button |
|
@Michael-Grover The pull request is merged now. What should I do? |
|
We can change that later. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #42
Change color to maintain at least 4.5 color contrastChanges
Flags
Related Issues