Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-markdown-editor):multi-para to list proper indent - I158 #252

Conversation

K-Kumar-01
Copy link
Contributor

Signed-off-by: k-kumar-01 kushalkumargupta4@gmail.com

Closes #158

Choosing multiple paragraphs and then converting them to list will now show points-bullet or numbers along with the indentation

Changes

  • Need to change the anchor and focus when selecting from bottom

Screenshots or Video

Selecting from bottom
Screenshot from 2021-02-20 23-49-03
Result
Screenshot from 2021-02-20 23-49-10

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to master from fork:branchname
  • Manual accessibility test performed
    • Keyboard-only access, including forms
    • Contrast at least WCAG Level A
    • Appropriate labels, alt text, and instructions

Signed-off-by: k-kumar-01 <kushalkumargupta4@gmail.com>
@Michael-Grover
Copy link

@K-Kumar-01 , it looks like there are some unsuccessful checks. If you need help, I recommend asking @irmerk or @dselman

@K-Kumar-01
Copy link
Contributor Author

@K-Kumar-01 , it looks like there are some unsuccessful checks. If you need help, I recommend asking @irmerk or @dselman
@Michael-Grover
I am unable to understand the failure of the checks.
@irmerk @dselman
Could you please tell me what is the error?

@irmerk
Copy link
Member

irmerk commented Feb 22, 2021

The error logs look strange to me... @K-Kumar-01 I'd suggest force pushing the same code up to force Netlify to rebuild and we can see what the issue is.

Added comment for explanation

Signed-off-by: k-kumar-01 <kushalkumargupta4@gmail.com>
@K-Kumar-01
Copy link
Contributor Author

The error logs look strange to me... @K-Kumar-01 I'd suggest force pushing the same code up to force Netlify to rebuild and we can see what the issue is.

@irmerk
I have added a commit(comment added) as I was not confident about force push.
@Michael-Grover
The PR build is successful now. Let me know if there are any changes required.

Copy link
Sponsor Contributor

@dselman dselman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dselman dselman merged commit 1da7634 into accordproject:master Feb 23, 2021
@K-Kumar-01 K-Kumar-01 deleted the k-kumar-01/i158/list-paragraph-indentation branch February 23, 2021 18:57
@mttrbrts mttrbrts added the Type: Bug 🐛 Something isn't working label Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing a group of paragraphs to a numbered list only indents the paragraphs
5 participants