Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui-markdown-editor): text deselection - #291 #292

Merged
merged 1 commit into from
Mar 12, 2021
Merged

fix(ui-markdown-editor): text deselection - #291 #292

merged 1 commit into from
Mar 12, 2021

Conversation

d-e-v-esh
Copy link
Contributor

Signed-off-by: d-e-v-esh 59534570+d-e-v-esh@users.noreply.github.com

Closes #291

Beforehand, selecting any kind of text and then clicking on the dropdown menu used to dismiss the selection. Now clicking on the drop-down menu does not affect the selected text.

Changes

  • A new function was added called onMouseDownHandler which was routed to the onMouseDown prop for the dropdown menu.
  • This function includes event.preventDefault() which fixes the issue.

Screenshots or Video

P1O6ZfAIYS

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to master from fork:branchname
  • Manual accessibility test performed
    • Keyboard-only access, including forms
    • Contrast at least WCAG Level A
    • Appropriate labels, alt text, and instructions

@d-e-v-esh
fix(ui-markdown-editor): text deselection - accordproject#291
e03670b 
Signed-off-by: d-e-v-esh <59534570+d-e-v-esh@users.noreply.github.com>
Michael-Grover
Michael-Grover approved these changes Mar 11, 2021
View reviewed changes
Copy link

@Michael-Grover Michael-Grover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an annoying bug. Thanks for the great fix!

@mttrbrts
Copy link
Member

Another nice fix! Good work @d-e-v-esh !

@mttrbrts mttrbrts merged commit 79bc7d1 into accordproject:master Mar 12, 2021
Cronus1007 added a commit to Cronus1007/web-components that referenced this pull request Mar 12, 2021
@Cronus1007
Merge pull request #1 from accordproject/master
4063bde 
fix(ui-markdown-editor): text deselection - accordproject#291 (accordproject#292)
Cronus1007 added a commit to Cronus1007/web-components that referenced this pull request Mar 12, 2021
@Cronus1007
Merge pull request #2 from accordproject/master
1c6ee38 
fix(ui-markdown-editor): text deselection - accordproject#291 (accordproject#292)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mttrbrts mttrbrts mttrbrts approved these changes

@Michael-Grover Michael-Grover Michael-Grover approved these changes

@irmerk irmerk Awaiting requested review from irmerk

@DianaLease DianaLease Awaiting requested review from DianaLease

@dselman dselman Awaiting requested review from dselman

Assignees

@d-e-v-esh d-e-v-esh

Labels
Difficulty: Starter Package: Markdown Editor ⌨️ Type: Bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

onClick of Drop-down style menu dismisses selected text
4 participants
@d-e-v-esh @mttrbrts @Michael-Grover @irmerk