Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: graphql api with graphql-module v1 #1141

Closed
wants to merge 6 commits into from

Conversation

pradel
Copy link
Member

@pradel pradel commented May 13, 2021

Closes #1079

  • Update documentation
  • Update examples
  • Manual testing of the previous features

@changeset-bot
Copy link

changeset-bot bot commented May 13, 2021

⚠️ No Changeset found

Latest commit: 66cfae1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Akarshit
Copy link
Contributor

Please let me know if I can help in any way to move this forward.

@loan-laux
Copy link

Also interested to help if I can!

@pradel
Copy link
Member Author

pradel commented May 25, 2021

@Akarshit @loan-laux I am in the middle of a moving so won't have time to finish this pr, I just pushed the last commit I did some days ago but if one of you want to finish the migration feel free 🙏

@loan-laux
Copy link

Good luck with the move, @pradel!

@darkbasic
Copy link
Member

I think I can help with this: I recently upgraded my projects to v1 and I also want to have a look at #1014 to see if I can make changes less drastic with v1.
If we can manage to fix those fundamental issues I will also update #1003 to v5 and I will finally be able to switch to accounts-js. At that point I will finally be able to put more time into this and implement the missing graphql resolvers (some strategies used to work only with the rest transport).

@pradel
Copy link
Member Author

pradel commented May 26, 2021

@darkbasic this sounds fantastic, feel free to ping me on slack if you need anything!

@loan-laux
Copy link

Looks like @tedraykov has made his own PR for that: #1147. Super excited to have this merged!

@pradel
Copy link
Member Author

pradel commented Dec 2, 2021

Closing in favor of #1189

@pradel pradel closed this Dec 2, 2021
@pradel pradel deleted the feature/graphql-modules-v1 branch December 2, 2021 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use graphql-modules v1 in @accounts/graphql-api
5 participants