-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix compatibility issue with MongoDB 4.X #1180
fix: fix compatibility issue with MongoDB 4.X #1180
Conversation
🦋 Changeset detectedLatest commit: acc94fe The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## master #1180 +/- ##
=======================================
Coverage 95.40% 95.40%
=======================================
Files 106 106
Lines 2351 2351
Branches 461 463 +2
=======================================
Hits 2243 2243
Misses 105 105
Partials 3 3
Continue to review full report at Codecov.
|
@rawb1 thanks for the fix! Instead of bumping mongo what do you think of keeping the old behavior, if the |
@pradel I think it is a great idea, I will update the PR tomorrow ! |
@pradel I've done the changes but the other way around as it is easier to check if I looked up the mongodb version the packages are using, I can look into doing the migration to v4 if you need ! @types/mongodb ^3.6.20 → ^4.0.6
mongodb ^3.4.1 → ^4.1.3 Btw great fan of the project, I used to be a big fan of meteor accounts package ! |
Migration to v4 would be amazing, we can release this one as a patch version and next pr in a separate minor version :) |
Could be a good idea to bump mongo version ? I did not find any information on mongo version compatibility ...
Fixes #1174