Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patch for issue in mongo driver 4.x.x #1209

Merged
merged 2 commits into from
Jan 17, 2022
Merged

fix: patch for issue in mongo driver 4.x.x #1209

merged 2 commits into from
Jan 17, 2022

Conversation

gezquinndesign
Copy link
Contributor

I know some issues were addressed in #1180. These are a couple of other issues that arise because in this version of the driver, the result of updateOne() and updateMany() is now different. Keeping previous check in there for backwards compatibility.

I know some issues were addressed in #1180.  These are a couple of other issues that arise because in this version of the driver, the result of updateOne() and updateMany() is now different.  Keeping previous check in there for backwards compatibility.
@changeset-bot
Copy link

changeset-bot bot commented Jan 14, 2022

⚠️ No Changeset found

Latest commit: 109d257

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #1209 (109d257) into master (0a40221) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1209   +/-   ##
=======================================
  Coverage   95.28%   95.28%           
=======================================
  Files         106      106           
  Lines        2377     2377           
  Branches      473      489   +16     
=======================================
  Hits         2265     2265           
+ Misses        107      103    -4     
- Partials        5        9    +4     
Impacted Files Coverage Δ
...ages/database-mongo-password/src/mongo-password.ts 100.00% <100.00%> (ø)
packages/oauth/src/accounts-oauth.ts 88.88% <0.00%> (ø)
packages/server/src/accounts-server.ts 90.70% <0.00%> (ø)
...s/graphql-api/src/utils/authenticated-directive.ts 27.27% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a40221...109d257. Read the comment docs.

@pradel
Copy link
Member

pradel commented Jan 15, 2022

Can you add the changeset file to the pr? Lgtm!

@gezquinndesign
Copy link
Contributor Author

Added. :)

@pradel pradel changed the title patch for issue in mongo driver 4.x.x fix: patch for issue in mongo driver 4.x.x Jan 17, 2022
@pradel pradel merged commit 5fa570d into accounts-js:master Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants