Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the api docs for all the packages #510

Merged
merged 8 commits into from
Nov 29, 2018
Merged

Show the api docs for all the packages #510

merged 8 commits into from
Nov 29, 2018

Conversation

pradel
Copy link
Member

@pradel pradel commented Nov 28, 2018

Types are generated by typedoc.
Inspired by graphql-modules for that 🎉

@codecov
Copy link

codecov bot commented Nov 28, 2018

Codecov Report

Merging #510 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #510   +/-   ##
=======================================
  Coverage   95.29%   95.29%           
=======================================
  Files          55       55           
  Lines        1274     1274           
  Branches      186      186           
=======================================
  Hits         1214     1214           
  Misses         55       55           
  Partials        5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c720979...db76ef5. Read the comment docs.

@aslafy-z
Copy link
Contributor

You may want to change the path prefix: /Users/leo/dev/accounts-js

As in here: https://github.com/accounts-js/accounts/pull/510/files#diff-691461362a3d6e161754c16706d27cfcR27

@pradel
Copy link
Member Author

pradel commented Nov 28, 2018

Nice catch thanks @aslafy-z !

Copy link
Member

@TimMikeladze TimMikeladze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.

@TimMikeladze
Copy link
Member

@pradel Can you add a link to the API docs to the repo's README?

@pradel pradel merged commit 3e70221 into master Nov 29, 2018
@delete-merged-branch delete-merged-branch bot deleted the feature/docs-api branch November 29, 2018 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants