Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

karmor summary flags are ignored #675

Closed
Vyom-Yadav opened this issue Mar 4, 2023 · 1 comment · Fixed by #679
Closed

karmor summary flags are ignored #675

Vyom-Yadav opened this issue Mar 4, 2023 · 1 comment · Fixed by #679

Comments

@Vyom-Yadav
Copy link
Contributor

func GetKubearmorSummaryData(req *opb.Request) ([]types.SysObsProcFileData, []types.SysObsProcFileData, []types.SysObsNwData, types.ObsPodDetail) {
var err error
var processData, fileData []types.SysObsProcFileData
var nwData []types.SysObsNwData
var podInfo types.ObsPodDetail
sysSummary, err := libs.GetSystemSummary(CfgDB, types.SystemSummary{
PodName: req.PodName,
})

Only req.PodName is respected, the rest of the parameters in the request are ignored.

$ karmor summary -p pod-1 --container redis
local port to be used for port forwarding discovery-engine-746fccb855-nlr6k: 32897 

  Pod Name        pod-1  
  Namespace Name  default                             
  Cluster Name    default                             
  Container Name  nginx                               
  Labels          app=nginx-client-side               
...
@Vyom-Yadav
Copy link
Contributor Author

Vyom-Yadav commented Mar 4, 2023

/assign (maintainers, please manually assign it to me)

Vyom-Yadav added a commit to Vyom-Yadav/discovery-engine that referenced this issue Mar 6, 2023
Vyom-Yadav added a commit to Vyom-Yadav/discovery-engine that referenced this issue Mar 6, 2023
Signed-off-by: Vyom-Yadav <jackhammervyom@gmail.com>
seswarrajan pushed a commit that referenced this issue Mar 7, 2023
Signed-off-by: Vyom-Yadav <jackhammervyom@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant