Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #675: karmor summary flags are ignored #679

Merged
merged 1 commit into from Mar 7, 2023
Merged

Issue #675: karmor summary flags are ignored #679

merged 1 commit into from Mar 7, 2023

Conversation

Vyom-Yadav
Copy link
Contributor

@Vyom-Yadav Vyom-Yadav commented Mar 6, 2023 •
edited

Closes #675

PR for kubearmor-client: kubearmor/kubearmor-client#276

@Vyom-Yadav Vyom-Yadav mentioned this pull request Mar 6, 2023
Merged
@Vyom-Yadav
Issue accuknox#675: karmor summary flags are ignored
81bea08 
Signed-off-by: Vyom-Yadav <jackhammervyom@gmail.com>
@nyrahul nyrahul requested a review from seswarrajan March 6, 2023 18:13
seswarrajan
seswarrajan reviewed Mar 7, 2023
View reviewed changes
Copy link
Contributor

@seswarrajan seswarrajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vyom-Yadav
This change LGTM.

Is it possible to modify the protobug request structure to include deployment_name as well, The SQL code already supports the change for that.

@Vyom-Yadav
Copy link
Contributor Author

Is it possible to modify the protobug request structure to include deployment_name as well, The SQL code already supports the change for that.

Do we want deployment_name in response too?

@seswarrajan
Copy link
Contributor

It would be better if we have the deployment name in field as well.

@Vyom-Yadav
Copy link
Contributor Author

We return just the pod_name in response, do we want to return the deployment_name too? Of course, it will be shown only if it's not empty.

@seswarrajan seswarrajan self-requested a review March 7, 2023 06:26
@seswarrajan
Copy link
Contributor

We return just the pod_name in response, do we want to return the deployment_name too? Of course, it will be shown only if it's not empty.

We can handle this in a separate PR

@seswarrajan seswarrajan merged commit 03fbded into accuknox:dev Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seswarrajan seswarrajan seswarrajan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

karmor summary flags are ignored
2 participants
@Vyom-Yadav @seswarrajan