chart updated #441
Merged
chart updated #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@nyrahul please review and merge it |
nyrahul
requested changes
Mar 21, 2022
Comment on lines
56
to
62
| cilium-hubble: | ||
| url: hubble-relay.kube-system.svc.cluster.local | ||
| port: 80 | ||
|
|
||
| kubearmor: | ||
| url: kubearmor.kube-system.svc.cluster.local | ||
| port: 32767 |
There was a problem hiding this comment.
Can we also have namespace configurable for cilium and kubearmor?
--cilium-ns xyz
--kubearmor-ns xyz
default is kube-system
knox-auto-policy-chart/values.yaml
Outdated
| cilium-hubble: | ||
| url: 10.4.41.240 | ||
| port: 80 | ||
| # config: |
There was a problem hiding this comment.
can we delete these commented configs?
There was a problem hiding this comment.
@nyrahul I have made changes, please review it
nyrahul
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.