Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty descriptions - meta data quality #74

Closed
3 tasks done
patrickakk opened this issue May 31, 2023 · 10 comments
Closed
3 tasks done

Empty descriptions - meta data quality #74

patrickakk opened this issue May 31, 2023 · 10 comments
Labels
Admin Admin - Part of application FeatureRequest New feature request - Kind of issue FrontEnd Front End - Part of application ToDo Ready to start development - Status of issue
Milestone

Comments

@patrickakk
Copy link
Contributor

patrickakk commented May 31, 2023

@PixlTracer @IvdL22 @vronk

As discussed in the meeting today:

  • Provide a list of all courses with empty descriptions (Patrick)
  • This will be discussed during the WG meeting, how moderators can contribute to fix this. (Anna & Iulliana)
  • Do now allow empty descriptions. Validation in model and DB (Patrick)
@patrickakk patrickakk added FeatureRequest New feature request - Kind of issue FrontEnd Front End - Part of application Admin Admin - Part of application ToDo Ready to start development - Status of issue labels May 31, 2023
@patrickakk patrickakk added this to the Mai 2023 milestone May 31, 2023
patrickakk added a commit that referenced this issue Jun 1, 2023
@patrickakk patrickakk removed their assignment Jun 1, 2023
@patrickakk patrickakk added InReview Request from dev to test and give feedback on the implementation of the issue - Status of issue and removed ToDo Ready to start development - Status of issue labels Jun 1, 2023
@patrickakk
Copy link
Contributor Author

@PixlTracer @vronk @IvdL22

Today I took a look at the production database and found 90 courses with an empty description. Those courses are all archived and not public shown.
So there won't be a list to discuss at the WG meeting?
For now we don't need to take an action on this?

The example I mentioned of a course with empty description happened at the end of last year and has been fixed by now.

Please understand that I don't look at every course separately. So I only see things when testing a new feature. In that case, of course, I can mention this.

So the good news is that, in the active/public shown courses, we currently don't have this problem.

I have changed the model, so that the field description will be required in release 2023-05.
This can be tested here:
https://dev-dhcr.clarin-dariah.eu/courses/add

It is not changed in the database, since this is not possible because of the old courses without description.

Can you review this and change the label to done, when you agree that no further actions are needed?

@IvdL22
Copy link

IvdL22 commented Jun 7, 2023

Thank you @patrickakk (cc @PixlTracer ). This is fine now. Would it be possible to extend a bit the suggestion of the text in grey "Please provide the course descriptions in English."

Some participants of our second workshop yesterday at DARIAH2023 asked to encourage course, contributors, to also include the learning outcomes in the course descriptions. Hence, I would like to suggest the following text:

"Please add in English the general aims of the course/programme and the learning outcomes."

Ok to include this request in here or do you want me to open a new issue?
thank you

@patrickakk
Copy link
Contributor Author

@IvdL22 (cc @PixlTracer ) It's fine to add it here. The change has been implemented in 2023-05. You can check it here:
https://dev-dhcr.clarin-dariah.eu/courses/add

Note: This text is only shown when the field description is empty, so when adding a new course. If you want a message which is also shown when the course is updated/edited, it could be done like the line below ECTS.

Can you change the label to "Done" when you're satisfied and this issue can be closed?

@PixlTracer
Copy link

Hi all,
checked the Description Field in dev (screenshot) and it seems that the additional sentence proposed by Iulianna has not been implemented (yet?)
@patrickakk can you change the text in the description field from "Please provide the course description in English" to
"Please provide the course description in English, as well as the general aims of the course/programme and the learning outcomes."
thanks!
Bildschirmfoto 2023-06-13 um 14 43 04

@patrickakk
Copy link
Contributor Author

@PixlTracer Did you check the link, specified in the comment above ? (#74 (comment))
(cc @IvdL22 )

The text -as specified by Iulliana- is there ? See screenshot:
image

Can you change the label to "Done" when you're satisfied and this issue can be closed?

@IvdL22
Copy link

IvdL22 commented Jun 23, 2023

@patrickakk Done, thanks!

@IvdL22 IvdL22 closed this as completed Jun 23, 2023
@IvdL22 IvdL22 added the Done Development and review process finished. Ready for release - Status of issue label Jun 23, 2023
@patrickakk patrickakk reopened this Jun 27, 2023
@patrickakk
Copy link
Contributor Author

The change above is implemented in 2023-05.

@patrickakk patrickakk assigned patrickakk and unassigned IvdL22 and PixlTracer Jun 27, 2023
@patrickakk patrickakk removed the InReview Request from dev to test and give feedback on the implementation of the issue - Status of issue label Jun 27, 2023
@patrickakk patrickakk added InDev Currently in development – Status of issue and removed Done Development and review process finished. Ready for release - Status of issue QuickCheck labels Jun 27, 2023
@patrickakk patrickakk modified the milestones: Mai 2023, July 2023 Jun 27, 2023
@patrickakk
Copy link
Contributor Author

When using another approach, it seems like there are still a lot of courses with empty descriptions.

I'll check that and get back on it.

@patrickakk patrickakk added ToDo Ready to start development - Status of issue and removed InDev Currently in development – Status of issue labels Jul 31, 2023
@patrickakk patrickakk modified the milestones: July 2023, September 2023 Jul 31, 2023
@patrickakk
Copy link
Contributor Author

Moved to November milestone, since we're still not finished with cleaning up duplicate user accounts. (See #50).

And too much "lists" might be confusing.

@patrickakk patrickakk removed this from the November 2023 milestone Nov 15, 2023
@patrickakk patrickakk removed their assignment Nov 15, 2023
@patrickakk patrickakk added this to the 2024 milestone Dec 5, 2023
@patrickakk patrickakk modified the milestones: 2024, June 2024 Mar 27, 2024
@patrickakk patrickakk modified the milestones: June 2024, Mai 2024 May 12, 2024
@patrickakk
Copy link
Contributor Author

@IvdL22 @PixlTracer

Just for info:
Now I've checked this again. The empty descriptions were probably only from older/not visible courses. From the currently public visible courses, almost all have descriptions available.

Probably also because of:

I have changed the model, so that the field description will be required in release 2023-05.

So it seems that everything is solved and the issue can be closed (again).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Admin - Part of application FeatureRequest New feature request - Kind of issue FrontEnd Front End - Part of application ToDo Ready to start development - Status of issue
Projects
None yet
Development

No branches or pull requests

3 participants