Use eager factory optimization only in production env (close #442) (#473

)

* Use eager factory optimization only in production env (close #442)

* Refactor using env check in createEagerElementUtil

* Remove check for propTypes

src/packages/recompose/__tests__/createElement-test.js

@@ -2,6 +2,12 @@ import React, { Component } from 'react'
 import { shallow } from 'enzyme'
 import createEagerElement from '../createEagerElement'
 
+const origNodeEnv = process.env.NODE_ENV
+
+afterEach(() => {
+  process.env.NODE_ENV = origNodeEnv
+})
+
 test('createEagerElement treats class components normally', () => {
   class InnerDiv extends Component {
     render() {
@@ -31,6 +37,7 @@ test('createEagerElement treats class components normally', () => {
 })
 
 test('createEagerElement calls stateless function components instead of creating an intermediate React element', () => {
+  process.env.NODE_ENV = 'production'
   const InnerDiv = () => <div data-bar="baz" />
   const OuterDiv = () =>
     createEagerElement(
@@ -64,6 +71,7 @@ test('createEagerElement handles keyed elements correctly', () => {
 })
 
 test('createEagerElement passes children correctly', () => {
+  process.env.NODE_ENV = 'production'
   const Div = props => <div {...props} />
   const InnerDiv = () => <div data-bar="baz" />
   const OuterDiv = () =>

src/packages/recompose/__tests__/hoistStatics-test.js

@@ -1,5 +1,5 @@
 import React from 'react'
-import { shallow } from 'enzyme'
+import { mount } from 'enzyme'
 import sinon from 'sinon'
 import { hoistStatics, mapProps } from '../'
 
@@ -13,6 +13,6 @@ test('copies non-React static properties from base component to new component',
 
   expect(EnhancedComponent.foo).toBe(BaseComponent.foo)
 
-  shallow(<EnhancedComponent n={3} />)
+  mount(<EnhancedComponent n={3} />)
   expect(BaseComponent.firstCall.args[0].n).toBe(15)
 })

src/packages/recompose/__tests__/isReferentiallyTransparentFunctionComponent-test.js

@@ -46,9 +46,9 @@ test('isReferentiallyTransparentFunctionComponent returns false for functions th
   expect(isReferentiallyTransparentFunctionComponent(Foo)).toBe(false)
 })
 
-test('isReferentiallyTransparentFunctionComponent returns false for functions that use propTypes', () => {
+test('isReferentiallyTransparentFunctionComponent returns true for functions that use propTypes', () => {
   const Foo = (props, context) => <div {...props} {...context} />
   Foo.propTypes = { store: PropTypes.object }
 
-  expect(isReferentiallyTransparentFunctionComponent(Foo)).toBe(false)
+  expect(isReferentiallyTransparentFunctionComponent(Foo)).toBe(true)
 })

src/packages/recompose/__tests__/renameProp-test.js

@@ -1,5 +1,5 @@
 import React from 'react'
-import { shallow } from 'enzyme'
+import { mount } from 'enzyme'
 import { withProps, renameProp, compose } from '../'
 
 test('renameProp renames a single prop', () => {
@@ -10,6 +10,6 @@ test('renameProp renames a single prop', () => {
 
   expect(StringConcat.displayName).toBe('withProps(renameProp(div))')
 
-  const div = shallow(<StringConcat />).find('div')
+  const div = mount(<StringConcat />).find('div')
   expect(div.props()).toEqual({ 'data-do': 123, 'data-la': 456 })
 })

src/packages/recompose/__tests__/renameProps-test.js

@@ -1,5 +1,5 @@
 import React from 'react'
-import { shallow } from 'enzyme'
+import { mount } from 'enzyme'
 import { withProps, renameProps, compose } from '../'
 
 test('renameProps renames props', () => {
@@ -10,7 +10,7 @@ test('renameProps renames props', () => {
 
   expect(StringConcat.displayName).toBe('withProps(renameProps(div))')
 
-  const div = shallow(<StringConcat />).find('div')
+  const div = mount(<StringConcat />).find('div')
 
   expect(div.prop('data-do')).toBe(123)
   expect(div.prop('data-fa')).toBe(456)

src/packages/recompose/isReferentiallyTransparentFunctionComponent.js

@@ -5,8 +5,7 @@ const isReferentiallyTransparentFunctionComponent = Component =>
     typeof Component === 'function' &&
       !isClassComponent(Component) &&
       !Component.defaultProps &&
-      !Component.contextTypes &&
-      (process.env.NODE_ENV === 'production' || !Component.propTypes)
+      !Component.contextTypes
   )
 
 export default isReferentiallyTransparentFunctionComponent

src/packages/recompose/utils/createEagerElementUtil.js

@@ -7,7 +7,11 @@ const createEagerElementUtil = (
   props,
   children
 ) => {
-  if (!hasKey && isReferentiallyTransparent) {
+  if (
+    process.env.NODE_ENV === 'production' &&
+    !hasKey &&
+    isReferentiallyTransparent
+  ) {
     if (children) {
       return type({ ...props, children })
     }