Skip to content
This repository has been archived by the owner on Sep 10, 2022. It is now read-only.

removing omit #119

Merged
merged 1 commit into from
Apr 20, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/packages/recompose/__tests__/mapPropsOnChange-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ describe('mapPropsOnChange()', () => {
renderIntoDocument(<StringConcat />)

expect(omit(spy.getProps(), ['updateStrings'])).to.eql({
a: 'a',
b: 'b',
c: 'c',
foobar: 'ab',
d: 'new'
Expand All @@ -44,13 +46,17 @@ describe('mapPropsOnChange()', () => {
expect(mapSpy.callCount).to.equal(1)

expect(omit(spy.getProps(), ['updateStrings', 'updateFoobar'])).to.eql({
a: 'a',
b: 'b',
c: 'baz',
foobar: 'ab',
d: 'new'
})

spy.getProps().updateStrings(strings => ({ ...strings, a: 'foo', 'b': 'bar', d: 'old' }))
expect(omit(spy.getProps(), ['updateStrings', 'updateFoobar'])).to.eql({
a: 'foo',
b: 'bar',
c: 'baz',
foobar: 'foobar',
d: 'new'
Expand Down
3 changes: 1 addition & 2 deletions src/packages/recompose/mapPropsOnChange.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { Component } from 'react'
import pick from 'lodash/pick'
import omit from 'lodash/omit'
import shallowEqual from './shallowEqual'
import createHelper from './createHelper'
import createElement from './createElement'
Expand All @@ -22,7 +21,7 @@ const mapPropsOnChange = (depdendentPropKeys, propsMapper) => BaseComponent => {

render() {
return createElement(BaseComponent, {
...omit(this.props, depdendentPropKeys),
...this.props,
...this.computedProps
})
}
Expand Down