Skip to content
This repository has been archived by the owner on Sep 10, 2022. It is now read-only.

Add a test for mapPropsOnChange #132

Merged
merged 1 commit into from
Apr 21, 2016
Merged

Add a test for mapPropsOnChange #132

merged 1 commit into from
Apr 21, 2016

Conversation

wuct
Copy link
Contributor

@wuct wuct commented Apr 21, 2016

This PR shows an unexpected behavior of mapPropsOnChange.

Please see #119

@codecov-io
Copy link

Current coverage is 98.23%

Merging #132 into master will not affect coverage as of b19a3a4

@@            master    #132   diff @@
======================================
  Files           40      40       
  Stmts          283     283       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit            278     278       
  Partial          0       0       
  Missed           5       5       

Review entire Coverage Diff as of b19a3a4

Powered by Codecov. Updated on successful CI builds.

@wuct
Copy link
Contributor Author

wuct commented Apr 21, 2016

I am not sure why the Travis CI build passed, but there is a test failed (as expected).

  ✖ mapPropsOnChange maps subset of owner props to child props   
  t.is(div.prop('c'), 'baz')
           |                
           "c"              

  1 test failed
  1. mapPropsOnChange maps subset of owner props to child props
  AssertionError: 'c' === 'baz'

@acdlite
Copy link
Owner

acdlite commented Apr 21, 2016

@wuct Yeah I'm aware of the false positives on Travis. It's due to the Ava workaround script we're using.

@acdlite acdlite merged commit 320862f into acdlite:master Apr 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants