This repository has been archived by the owner on Sep 10, 2022. It is now read-only.
withReducer: optionally initialize state from default reducer argument #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istarkov
reviewed
Sep 27, 2016
| }; | ||
|
|
||
| initalizeStateValue() { | ||
| if (typeof initialState !== 'undefined') { |
There was a problem hiding this comment.
initialState !== undefined is enough, why typeof here?
There was a problem hiding this comment.
Don't know.
This is just my habit from the time when it was possible to define variable named undefined.
Fixed this.
|
Thank you!!! |
|
See #247 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #247
See linked issue for reasons of this change