componentFromStream can potentially throw EmptyError: no elements in sequence

[avocadowastaken]

As from 0.22.0 componentFromStream will complete the stream during unmount and usage of first, last or single methods can potentially throw EmptyError.

See #220 and #303

[istarkov]

are u sure https://github.com/acdlite/recompose/blob/master/src/packages/recompose/componentFromStream.js#L41
any example with real life error throwing?

[avocadowastaken]

Had this problem in my project after update. It was cause with propsStream.filter(props => props.id > 0).first() like streams. I'll add test cases bit later.

[istarkov]

Ill add a ref to this thread here https://github.com/acdlite/recompose/releases/tag/v0.22.0
dont think that documentation is the place for possible issues

[istarkov]

Done, thank you.

[avocadowastaken]

any example with real life error throwing?

Done

dont think that documentation is the place for possible issues

I thought it would be good for new users to know about this gotcha. And yes, for old users release description is better place.

[istarkov]

May we move changes from documentation into first comment here and Ill merge the test only?

[istarkov]

I think for new users it will be well described understandable rx error, isnt it?

[istarkov]

Or may be change documentation as now its not obvious why such exception should occur

[avocadowastaken]

May we move changes from documentation into first comment here and Ill merge the test only?

Done

Or may be change documentation as now its not obvious why such exception should occur

I'm not good at documenting things :).

[istarkov]

A rare persons are good in documentation. My own projects some kind of documentation hell ;-)

[istarkov]

Thank you!!!