Build umd with rollup

[TrySound]

build

• Recompose.js 76 360 -> 35 623
• Recompose.js 28 877 -> 13 028

Also I'd like to bundle es modules version soon

[istarkov]

Super! Will look today. Thank you

[istarkov]

Can you fix linter errors? I know we have not check them in package.json lint rule, but it's our mistake.

[TrySound]

Okay

[TrySound]

Do you mean release.js or that no-console wraning?

[istarkov]

All 50+ after this command ;-)

./node_modules/.bin/eslint ./scripts/ ./rollup.config.js

[istarkov]

Also I've got Unknown plugin "babel-plugin-external-helpers" specified in "base" at 23, attempted to resolve rel ative to "/Users/ice/ext/npm/recompose/src/packages/recompose"

[istarkov]

Also (I'm just curious) haven't you investigated what causes so big size decrease? webpack module headers or some dependency?

PS: Or may be babel-plugin-external-helpers?

[TrySound]

Webpack adds some boilerplate for each module. Maybe something in deps was treeshaked. Maybe Babel helpers. Or all together)

[TrySound]

@acdlite So much changed since yesterday :))

[TrySound]

Maybe fixing test fail is the purpose of different PR?

[istarkov]

Yes currently in progress #344

…

On Sat, Apr 8, 2017 at 1:24 AM, Bogdan Chadkin ***@***.***> wrote: Maybe fixing test fail is the purpose of different PR? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#341 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE14Mp-PmOozRI7AHgd9hWwlIkwZHlqQks5rtreYgaJpZM4M2Tpv> .

[TrySound]

Wow, found 11 Object.assign and a lot more helpers. I guess this is one of main wins.

[istarkov]

I'm having strange behaviour trying to preview build results without your PR just adding babel-plugin-external-helpers and trying to build the project npm run release

/Users/ice/ext/npm/recompose/scripts/release.js:5
var _fs2 = babelHelpers.interopRequireDefault(_fs);
           ^

ReferenceError: babelHelpers is not defined

I haven't used helpers, what it can be?

PS: based on this http://babeljs.io/docs/plugins/external-helpers/ do we need to build them?

[istarkov]

Have you tried resulting umd build? The same error can be there.

[TrySound]

Rollup plugin Babel adds necessary helpers. Babel loader seems not.

[TrySound]

Or its babel-node. You should have different config or add env variables. This however didn't worked in this PR. I'll try to fix it later. Maybe we even don't need babel-node, caz the last node is pretty babeled. :)

[istarkov]

Super, Thank you a lot!!!