This repository has been archived by the owner on Sep 10, 2022. It is now read-only.
Fix lifecycle to support React 15.5 #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe just object assign? It is still exists in helpers. |
|
You are right |
|
@TrySound fixed, thank you! |
Why ? I'm wondering whether I should start using it in my project, thank you for your answer |
|
@romseguy you can get the idea from #521 (comment). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason: https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html#migrating-from-react.createclass
Removing
createClassat all fromlifecycle.(importing it from
create-react-classwill cause current package incompatibility with React 14, and all thatrequirewith version check is not better than current solution )Also IMO
lifecyclemust be deprecated or even removed from recompose.And yes possibly breaking change.