This repository has been archived by the owner on Sep 10, 2022. It is now read-only.
add flattenProps #366
Closed
Closed
add flattenProps #366
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
import React from 'react' | ||
import { shallow } from 'enzyme' | ||
import { flattenProps } from '../' | ||
|
||
test('flattenProps flattens object props and spreads them into the top-level props object', () => { | ||
const Counter = flattenProps(['data-first', 'data-second'])('div') | ||
expect(Counter.displayName).toBe('flattenProps(div)') | ||
|
||
const wrapper = shallow( | ||
<Counter | ||
data-pass="through" | ||
data-first={{ 'data-foo': 1 }} | ||
data-second={{ 'data-bar': 2 }} | ||
/> | ||
) | ||
|
||
expect( | ||
wrapper.equals( | ||
<div | ||
data-pass="through" | ||
data-first={{ 'data-foo': 1 }} | ||
data-second={{ 'data-bar': 2 }} | ||
data-foo={1} | ||
data-bar={2} | ||
/> | ||
) | ||
).toBe(true) | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
import createHelper from './createHelper' | ||
import createEagerFactory from './createEagerFactory' | ||
|
||
const flattenProps = propNames => BaseComponent => { | ||
const factory = createEagerFactory(BaseComponent) | ||
|
||
return props => | ||
factory({ | ||
...props, | ||
...propNames.reduce( | ||
(flattenedProps, propName) => ({ | ||
...flattenedProps, | ||
...props[propName], | ||
}), | ||
{} | ||
), | ||
}) | ||
} | ||
|
||
export default createHelper(flattenProps, 'flattenProps') |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a "library-like" utility function, maybe it would be worth it to mutate in the reducer. It's ugly, sure, but it performs better:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
every pure function is impure at assembler level - istarkov :-)