Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New method for handle damage #2668

Closed
wants to merge 1 commit into from
Closed

New method for handle damage #2668

wants to merge 1 commit into from

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Oct 2, 2015

replaces: #2375

@commy2 commy2 added kind/enhancement Release Notes: **IMPROVED:** status/experimental labels Oct 2, 2015
@commy2 commy2 self-assigned this Oct 2, 2015
@commy2 commy2 added this to the Backlog milestone Oct 2, 2015
["medical_selectionDamage", {_this call FUNC(handleSelectionDamage)}] call EFUNC(common,addEventhandler);
["medical_fallDamage", {_this call FUNC(handleFallDamage)}] call EFUNC(common,addEventhandler);
["medical_drowningDamage", {_this call FUNC(handleDrowningDamage)}] call EFUNC(common,addEventhandler);
["medical_collisionDamage", {_this call FUNC(handleCollisionDamage)}] call EFUNC(common,addEventhandler);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing this might look good, but is actually bad practice to do with git in mind. Adding or changing one line and having to adjust other lines makes it so the chance of having merge conflicts is increased.

@jokoho48
Copy link
Member

jokoho48 commented Oct 5, 2015

@commy2 PLEASE remove your Comment PLEASE else i could try to kill you

@thojkooi thojkooi mentioned this pull request Jan 9, 2016
14 tasks
@thojkooi
Copy link
Contributor

Closing in favour of #3174

@thojkooi thojkooi closed this Jan 19, 2016
@commy2 commy2 deleted the 340handledamage branch February 16, 2016 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:** status/experimental
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants