Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove enable optics in adjusted prone stances #2703

Merged
merged 2 commits into from Nov 17, 2015
Merged

Remove enable optics in adjusted prone stances #2703

merged 2 commits into from Nov 17, 2015

Conversation

jonpas
Copy link
Member

@jonpas jonpas commented Oct 7, 2015

From https://forums.bistudio.com/topic/140837-development-branch-changelog/?p=2922316:

Fixed: Couldn't use sights in adjusted prone stance

If someone could confirm that on dev-branch that would be great, either way this PR removes that fix from ACE3, please set milestone to Backlog for now until it is in vanilla (stable branch).

@PabstMirror PabstMirror added this to the Backlog milestone Oct 7, 2015
@commy2 commy2 self-assigned this Oct 7, 2015
};
class AadjPpneMstpSrasWrflDup;
class AadjPpneMstpSrasWrflDdown: AadjPpneMstpSrasWrflDup {
enableOptics = 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not enabled in 1.54 dev

@commy2
Copy link
Contributor

commy2 commented Oct 20, 2015

@jonpas You removed to much. The prone down anims don't have optics enabled.

@commy2 commy2 added status/WIP kind/cleanup Release Notes: **CHANGED:** labels Oct 20, 2015
@commy2
Copy link
Contributor

commy2 commented Oct 20, 2015

also baby colors. yay!

@commy2 commy2 modified the milestones: 3.4.0, Backlog Oct 28, 2015
@PabstMirror
Copy link
Contributor

1.54 RC vanilla:

  • getNumber (configFile >> "CfgMovesMaleSdr" >> "States" >> "AadjPpneMstpSrasWrflDleft" >> "enableOptics") = 1
  • getNumber (configFile >> "CfgMovesMaleSdr" >> "States" >> "AadjPpneMstpSrasWrflDright" >> "enableOptics") = 1
  • getNumber (configFile >> "CfgMovesMaleSdr" >> "States" >> "AadjPpneMstpSrasWpstDleft" >> "enableOptics") = 2
  • getNumber (configFile >> "CfgMovesMaleSdr" >> "States" >> "AadjPpneMstpSrasWpstDright" >> "enableOptics") = 2

Matches what we're removing, so looks good to go 👍

commy2 added a commit that referenced this pull request Nov 17, 2015
Remove enable optics in adjusted prone stances
@commy2 commy2 merged commit b6f9a2b into acemod:master Nov 17, 2015
@jonpas jonpas deleted the removeAdjustedProneOptics branch November 17, 2015 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Release Notes: **CHANGED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants