Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup ambient sounds module #2847

Merged
merged 1 commit into from Nov 20, 2015
Merged

Cleanup ambient sounds module #2847

merged 1 commit into from Nov 20, 2015

Conversation

BaerMitUmlaut
Copy link
Member

Cleanup:

  • switch to params
  • removed unused privates
  • added previously not declared privates
  • merged two loops

Also fixed sounds not playing if the path had a leading backslash.

@PabstMirror PabstMirror added the kind/cleanup Release Notes: **CHANGED:** label Nov 16, 2015
@thojkooi thojkooi added this to the 3.4.0 milestone Nov 20, 2015
thojkooi added a commit that referenced this pull request Nov 20, 2015
@thojkooi
Merge pull request #2847 from BaerMitUmlaut/cleanup-moduleAmbianceSound
a652be8 
Cleanup ambient sounds module
@thojkooi thojkooi merged commit a652be8 into acemod:master Nov 20, 2015
@BaerMitUmlaut BaerMitUmlaut deleted the cleanup-moduleAmbianceSound branch December 3, 2015 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/cleanup Release Notes: **CHANGED:**
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BaerMitUmlaut @thojkooi @PabstMirror