Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auto add blown off turrets to curator #4425

Merged
merged 2 commits into from Sep 18, 2016
Merged

auto add blown off turrets to curator #4425

merged 2 commits into from Sep 18, 2016

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Sep 18, 2016 •
edited

When merged this pull request will:

  • make it so that blown off turrets are added to all curators that own the wreck
  • it also adds icons to the turrets. those huge ass question marks would be annoying, so I just use the corresponding tanks icon
  • also OCD formatting

http://i.imgur.com/8REyLfo.png

@commy2 commy2 added the kind/enhancement Release Notes: **IMPROVED:** label Sep 18, 2016
@commy2 commy2 added this to the 3.7.1 milestone Sep 18, 2016
@commy2 commy2 self-assigned this Sep 18, 2016
bux
bux requested changes Sep 18, 2016
View reviewed changes
Copy link
Member

@bux bux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misses displayName for the turret? Something generic like "Tank Turret Wreck"

@commy2
Copy link
Contributor Author

commy2 commented Sep 18, 2016

hmm. For some reason I cannot move or delete the turret. Zeus says: "INSUFICIENT RESOURCES". What does it mean with this?

@commy2
Copy link
Contributor Author

commy2 commented Sep 18, 2016

must've been a fluke. I can delete them just fine now.

@commy2 commy2 merged commit c4e35a7 into master Sep 18, 2016
@commy2 commy2 deleted the curator-editable-blown-off-turrets branch September 18, 2016 10:53
@jonpas jonpas modified the milestones: 3.7.1, 3.8.0 Sep 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bux bux bux approved these changes

@thojkooi thojkooi thojkooi approved these changes

Assignees

@commy2 commy2

Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@commy2 @bux @thojkooi @jonpas