-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CH53 Fastroping and other fixes #4713
Conversation
Added fastrope points for CH53. The getOut EH is required to keep the doors open when a unit exits the vehicle and it uses the vehicle animation "doorHandler_R" or "doorHandler_L" as a placeholder to determine if the doors are open(1)/close(0). eg. In UH1Y (Unarmed), when the right door is opened using the useraction, "doorRB" and "doorHandler_R" will be set to 1.
Pretty sure your changes to the getIn/Out EH will cause issues when on the ground. Needs testing. |
Currently, the getOut EH will only be executed if "ace_fastroping_doorsLocked" is false but the doors on the UH1Y and UH60M still closes automatically (on some occasions) if FRIES is "prepared" and when a unit gets in/out. So my suggestion is to allow the getOut EH to handle the door as per normal (without any conditions) while in "fnc_onPrepare.sqf", both "doorHandler_R" and "doorHandler_L" should be animated accordingly. As the "rhs_fnc_uh60_doors" function uses "doorHandler_R"/"doorHandler_L" to determine if the doors should be left open if a unit gets in/out. Original rhs_fnc_uh60_doors (uh60_doors.sqf) code:
|
I see, interesting. Have you tested if it works as expected? |
Yup, I've tested it and the doors stay open when intended |
@BaerMitUmlaut could you take another look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed conflicts in canCloseDoor.sqf
Tested CH53 fastroping, seems great
Added fastrope points for CH53.
The getOut EH is required to keep the doors open when a unit exits the
vehicle and it uses the vehicle animation "doorHandler_R" and
"doorHandler_L" as a placeholder to determine if the doors are
open(1)/close(0).
eg. In UH1Y (Unarmed), when the right door is opened using the
useraction, "doorRB" (animateDoor) and "doorHandler_R" (animate) will be set to 1.