Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CH53 Fastroping and other fixes #4713

Merged
merged 4 commits into from
May 29, 2017
Merged

CH53 Fastroping and other fixes #4713

merged 4 commits into from
May 29, 2017

Conversation

magicsh0tz
Copy link
Contributor

@magicsh0tz magicsh0tz commented Nov 26, 2016

Added fastrope points for CH53.

The getOut EH is required to keep the doors open when a unit exits the
vehicle and it uses the vehicle animation "doorHandler_R" and
"doorHandler_L" as a placeholder to determine if the doors are
open(1)/close(0).
eg. In UH1Y (Unarmed), when the right door is opened using the
useraction, "doorRB" (animateDoor) and "doorHandler_R" (animate) will be set to 1.

Added fastrope points for CH53.

The getOut EH is required to keep the doors open when a unit exits the
vehicle and it uses the vehicle animation "doorHandler_R" or
"doorHandler_L" as a placeholder to determine if the doors are
open(1)/close(0).
eg. In UH1Y (Unarmed), when the right door is opened using the
useraction, "doorRB" and "doorHandler_R" will be set to 1.
@jonpas jonpas added this to the 3.8.3 milestone Nov 26, 2016
@jonpas jonpas added the kind/enhancement Release Notes: **IMPROVED:** label Nov 26, 2016
@magicsh0tz magicsh0tz changed the title CH53 Fastroping and Fixes CH53 Fastroping and other fixes Nov 26, 2016
@BaerMitUmlaut BaerMitUmlaut self-assigned this Nov 28, 2016
@BaerMitUmlaut
Copy link
Member

Pretty sure your changes to the getIn/Out EH will cause issues when on the ground. Needs testing.

@magicsh0tz
Copy link
Contributor Author

magicsh0tz commented Nov 28, 2016

Currently, the getOut EH will only be executed if "ace_fastroping_doorsLocked" is false but the doors on the UH1Y and UH60M still closes automatically (on some occasions) if FRIES is "prepared" and when a unit gets in/out.

So my suggestion is to allow the getOut EH to handle the door as per normal (without any conditions) while in "fnc_onPrepare.sqf", both "doorHandler_R" and "doorHandler_L" should be animated accordingly. As the "rhs_fnc_uh60_doors" function uses "doorHandler_R"/"doorHandler_L" to determine if the doors should be left open if a unit gets in/out.

Original rhs_fnc_uh60_doors (uh60_doors.sqf) code:

/*
a: reyhard

door handling script
while doors are opened by action make sure they stay in such state
*/

if (_this select 1 == "cargo") then {
    private["_v"];

    _v = _this select 0;

    if (_v animationPhase "doorhandler_R" == 1) then {
        _v animateDoor ["doorRB",1];
    } else {
        if (_v doorPhase "doorRB" != 0) then {
            [_v,"doorRB"] spawn rhs_fnc_doorHandler;
        };
    };

    if (_v animationPhase "doorhandler_L" == 1) then {
        _v animateDoor ["doorLB",1];
    } else {
        if(_v doorPhase "doorLB" !=0) then {
            [_v,"doorLB"] spawn rhs_fnc_doorHandler;
        };
    };
};

@BaerMitUmlaut
Copy link
Member

I see, interesting. Have you tested if it works as expected?

@magicsh0tz
Copy link
Contributor Author

Yup, I've tested it and the doors stay open when intended

@thojkooi thojkooi modified the milestones: 3.9.0, 3.8.3 Dec 12, 2016
@PabstMirror PabstMirror modified the milestones: 3.9.1, 3.9.0 Feb 10, 2017
@thojkooi
Copy link
Contributor

thojkooi commented Mar 8, 2017

@BaerMitUmlaut could you take another look at this?

@thojkooi thojkooi modified the milestones: 3.10.0, 3.9.1 Mar 8, 2017
Copy link
Contributor

@PabstMirror PabstMirror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed conflicts in canCloseDoor.sqf
Tested CH53 fastroping, seems great

@PabstMirror PabstMirror merged commit cd85247 into acemod:master May 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants