Rearm - Pylon Support and Dynamically Add Supply Actions #5183
Conversation
There was a problem hiding this comment.
Pylon support 👍
Pylon hardpoint caching 👍
Dynamic actions 👍
One file with borked indentation 👎
Don't really like how every single function checks for argument input correctness and how they are spread into multiple lines because of that, but I won't make that stop the merge, just a comment. Not sure about performance at all.
| * | ||
| * Arguments: | ||
| * 0: Ammo Truck <OBJECT> | ||
| * 1: Vehicle object or Vehicle class <OBJECT><STRING> |
There was a problem hiding this comment.
Not true, params only accepts object.
There was a problem hiding this comment.
For 2nd arg string is fine
params [["_truck", objNull, [objNull]], ["_vehicle", objNull, [objNull, ""]]];
|
|
||
| private _turretConfig = _this call CBA_fnc_getTurret; | ||
|
|
||
| getArray (_turretConfig >> "magazines") |
There was a problem hiding this comment.
2 lines seem a bit redundant, just getArray (_this call CBA_fnc_getTurret >> "magazines") would do.
|
|
||
|
|
||
| private _actionReadSupplyCounter = [ // GVAR(supply) > 0 | ||
| QGVAR(ReadSupplyCounter), |
|
Are the |
| @@ -3,7 +3,7 @@ | |||
| #include "\z\ace\addons\main\script_mod.hpp" | |||
|
|
|||
| // #define DEBUG_MODE_FULL | |||
| // #define DISABLE_COMPILE_CACHE | |||
| #define DISABLE_COMPILE_CACHE | |||
There was a problem hiding this comment.
Was commented out again in #5260.
Merge after #5182
Progress on issue #5180 and #5173