Use getUnitTrait for medics, engineers and EOD

[kymckay]

When merged this pull request will:

• Make the functions which check whether units are medics, engineers or explosive specialists use the newer getUnitTrait command which makes them compatible with use of setUnitTrait and not purely checking the config

[PabstMirror]

_class should be number, not bool

someone in public slack was talking about using config attendant =2 to set doctors
it's not the prettiest code, but something like this should support that

private _class = _unit getVariable QGVAR(medicClass);
if (isNil "_class") then {
    if (_unit getUnitTrait "medic") then {
        _class = 1 max getNumber (configFile >> "CfgVehicles" >> typeOf _unit >> "attendant");
    } else{
        _class = 0;
    };
};

[kymckay]

Are we sure we want to support that since afaik the game itself treats the attendant property as a boolean?

[kymckay]

It might be better to introduce an extra config property to support doctors that way (although, are doctors even relevant in the current medical code?)

[Phyma]

ACE_common_fnc_getUnitTrait that will check all traits and "attendats"? Input of what you need to check. This will also help later if we decide to implement more types of medics, engineers and more.
Thoughts?

[jonpas]

I think that should be done in medical-rewrite, as we can afford to change things there that would otherwise be backwards-incompatible.

[kymckay]

I didn't add the code for attendant being set to 2 as I'm unsure about whether we want to do that, but fixed the incorrect boolean

[PabstMirror]

Could replace the attendant = 2; config with

class Extended_Init_EventHandlers {
    class x_doctorUnitType {
        class makeDoctor {
            init = "(_this select 0) setVariable ["ace_medical_medicClass", 2]";
        };
    };
};