Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle ace_cargo_canLoad set to scalar #5306

Merged
merged 1 commit into from Jun 23, 2017
Merged

Handle ace_cargo_canLoad set to scalar #5306

merged 1 commit into from Jun 23, 2017

Conversation

PabstMirror
Copy link
Contributor

var ace_cargo_canLoad used to be 0/1
some addons are still setting to scalar

e.g. r3f-logistics does

		_object setVariable ['ace_dragging_canCarry', false];
		_object setVariable ['ace_dragging_canDrag', false];
		_object setVariable ['ace_cargo_canLoad', 0];

Throws error

  Error ||: Type Number, expected Bool,code
 File z\ace\addons\cargo\functions\fnc_initObject.sqf, line 13

@PabstMirror PabstMirror added the kind/bug-fix Release Notes: **FIXED:** label Jun 23, 2017
@PabstMirror PabstMirror added this to the 3.11.0 milestone Jun 23, 2017
@PabstMirror PabstMirror requested a review from kymckay June 23, 2017 00:56
Copy link
Member

@kymckay kymckay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good solution 👍

It definitely makes more sense as a bool to me based on the variable name.

@PabstMirror PabstMirror merged commit fde984a into master Jun 23, 2017
@PabstMirror PabstMirror deleted the cargoCanLoadVar branch June 23, 2017 16:31
@PabstMirror PabstMirror modified the milestones: 3.10.2, 3.11.0 Jul 8, 2017
jonpas pushed a commit that referenced this pull request Jul 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants