Zeus - Group Side Module: preserve group id and assigned team #6569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrettMayson
commented
Sep 9, 2018
BrettMayson
changed the title
commy2
reviewed
Sep 10, 2018
PabstMirror
changed the title
BaerMitUmlaut
pushed a commit
that referenced
this pull request
Aug 5, 2019
* Group Side - preserve group id and assigned team * use findIf instead of breakOut
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Notes:
If the
Move units from group on unconscioussetting is enabled and a unit is unconscious when the module is used they will join the new group when they are woken up as expected. They will not keep their assigned team however and will join the white team when woken up. That would require changing code related to themoveUnitsFromGroupOnUnconscioussetting and I don't think it is worth it for this edge case.